Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_logpush: fix handling of timestamps for all available formats #7764

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 12, 2023

What does this PR do?

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cloudflare_logpush Cloudflare Logpush labels Sep 12, 2023
@efd6 efd6 self-assigned this Sep 12, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-12T01:26:40.291+0000

  • Duration: 25 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 96
Skipped 0
Total 96

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 100.0% (15/15) 💚
Classes 100.0% (15/15) 💚
Methods 100.0% (178/178) 💚
Lines 91.909% (4180/4548)
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review September 12, 2023 02:01
@efd6 efd6 requested a review from a team as a code owner September 12, 2023 02:01
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one minor suggestion, can we give some comments explaining the conversion logic used, I know it's simple to understand for many, but would be a nice QoL feature for the average reader. An updated description in the PR also works.

@efd6
Copy link
Contributor Author

efd6 commented Sep 12, 2023

I'll expand on it in the commit message.

@efd6 efd6 merged commit 7308338 into elastic:main Sep 12, 2023
1 check passed
@elasticmachine
Copy link

Package cloudflare_logpush - 1.8.1 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cloudflare_logpush Cloudflare Logpush
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants