-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudflare_logpush: fix handling of timestamps for all available formats #7764
Conversation
3e03007
to
41b5e3e
Compare
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one minor suggestion, can we give some comments explaining the conversion logic used, I know it's simple to understand for many, but would be a nice QoL feature for the average reader. An updated description in the PR also works.
I'll expand on it in the commit message. |
Package cloudflare_logpush - 1.8.1 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush |
What does this PR do?
See title.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots