Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STAN] Add subscriptions data stream metric types #7860

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Sep 18, 2023

What does this PR do?

Add metric types for subscriptions data stream fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

The dashboard for STAN metrics seems to be broken (this has to be addressed). I recreated the lenses just for visualization and data validation.

scrnli_9_22_2023_12-15-28 AM

@gpop63 gpop63 mentioned this pull request Sep 18, 2023
17 tasks
@gpop63 gpop63 self-assigned this Sep 18, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-30T10:14:47.543+0000

  • Duration: 19 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 18, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (20/20) 💚 13.889
Lines 95.477% (190/199) 👎 -0.666
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 force-pushed the stan_subscriptions_metric_types branch from 967edd2 to 0b6ef8b Compare September 21, 2023 21:44
@gpop63 gpop63 force-pushed the stan_subscriptions_metric_types branch from 0b6ef8b to 22f37c1 Compare September 21, 2023 21:46
@gpop63
Copy link
Contributor Author

gpop63 commented Sep 21, 2023

Rollover test
{
  "acknowledged": true,
  "shards_acknowledged": true,
  "old_index": ".ds-metrics-stan.subscriptions-default-2023.09.21-000001",
  "new_index": ".ds-metrics-stan.subscriptions-default-2023.09.21-000002",
  "rolled_over": true,
  "dry_run": false,
  "conditions": {}
}
Mappings
        "stan": {
          "properties": {
            "cluster": {
              "properties": {
                "id": {
                  "type": "keyword",
                  "time_series_dimension": true
                }
              }
            },
            "server": {
              "properties": {
                "id": {
                  "type": "keyword",
                  "time_series_dimension": true
                }
              }
            },
            "subscriptions": {
              "properties": {
                "channel": {
                  "type": "keyword",
                  "time_series_dimension": true
                },
                "id": {
                  "type": "keyword",
                  "time_series_dimension": true
                },
                "last_sent": {
                  "type": "long",
                  "time_series_metric": "counter"
                },
                "offline": {
                  "type": "boolean"
                },
                "pending": {
                  "type": "long",
                  "time_series_metric": "gauge"
                },
                "queue": {
                  "type": "keyword",
                  "time_series_dimension": true
                },
                "stalled": {
                  "type": "boolean"
                }
              }
            }
          }
        }

@gpop63 gpop63 marked this pull request as ready for review September 21, 2023 22:07
@gpop63 gpop63 requested a review from a team as a code owner September 21, 2023 22:07
@gpop63
Copy link
Contributor Author

gpop63 commented Oct 19, 2023

TSDB testing kit output:

Testing data stream metrics-stan.subscriptions-default.
Index being used for the documents is .ds-metrics-stan.subscriptions-default-2023.10.18-000001.
Index being used for the settings and mappings is .ds-metrics-stan.subscriptions-default-2023.10.18-000001.

The time series fields for the TSDB index are: 
        - dimension (14 fields):
                - agent.id
                - cloud.account.id
                - cloud.availability_zone
                - cloud.instance.id
                - cloud.provider
                - cloud.region
                - container.id
                - host.name
                - service.address
                - stan.cluster.id
                - stan.server.id
                - stan.subscriptions.channel
                - stan.subscriptions.id
                - stan.subscriptions.queue
        - counter (1 fields):
                - stan.subscriptions.last_sent
        - gauge (1 fields):
                - stan.subscriptions.pending
        - routing_path (14 fields):
                - agent.id
                - cloud.account.id
                - cloud.availability_zone
                - cloud.instance.id
                - cloud.provider
                - cloud.region
                - container.id
                - host.name
                - service.address
                - stan.cluster.id
                - stan.server.id
                - stan.subscriptions.channel
                - stan.subscriptions.id
                - stan.subscriptions.queue

Index tsdb-index-enabled successfully created.

Copying documents from .ds-metrics-stan.subscriptions-default-2023.10.18-000001 to tsdb-index-enabled...
All 14261 documents taken from index .ds-metrics-stan.subscriptions-default-2023.10.18-000001 were successfully placed to index tsdb-index-enabled.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gpop63 gpop63 merged commit f7020cf into elastic:main Oct 30, 2023
4 checks passed
@elasticmachine
Copy link

Package stan - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=stan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants