-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STAN] Add subscriptions data stream metric types #7860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌐 Coverage report
|
gpop63
force-pushed
the
stan_subscriptions_metric_types
branch
from
September 21, 2023 21:44
967edd2
to
0b6ef8b
Compare
gpop63
force-pushed
the
stan_subscriptions_metric_types
branch
from
September 21, 2023 21:46
0b6ef8b
to
22f37c1
Compare
Rollover test{
"acknowledged": true,
"shards_acknowledged": true,
"old_index": ".ds-metrics-stan.subscriptions-default-2023.09.21-000001",
"new_index": ".ds-metrics-stan.subscriptions-default-2023.09.21-000002",
"rolled_over": true,
"dry_run": false,
"conditions": {}
} Mappings "stan": {
"properties": {
"cluster": {
"properties": {
"id": {
"type": "keyword",
"time_series_dimension": true
}
}
},
"server": {
"properties": {
"id": {
"type": "keyword",
"time_series_dimension": true
}
}
},
"subscriptions": {
"properties": {
"channel": {
"type": "keyword",
"time_series_dimension": true
},
"id": {
"type": "keyword",
"time_series_dimension": true
},
"last_sent": {
"type": "long",
"time_series_metric": "counter"
},
"offline": {
"type": "boolean"
},
"pending": {
"type": "long",
"time_series_metric": "gauge"
},
"queue": {
"type": "keyword",
"time_series_dimension": true
},
"stalled": {
"type": "boolean"
}
}
}
}
} |
TSDB testing kit output:
|
agithomas
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
constanca-m
approved these changes
Oct 30, 2023
Package stan - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=stan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add metric types for
subscriptions
data stream fields.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots
The dashboard for STAN metrics seems to be broken (this has to be addressed). I recreated the lenses just for visualization and data validation.