Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing detection rules from the ded package #7947

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Conversation

ajosh0504
Copy link
Contributor

What does this PR do?

This PR moves detection rules associated with Data Exfiltration Detection (ded) out of the integration package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Spin up a local Elasticsearch cluster
  • Verify that the package version shown is 2.0.0, Subscription is platinum and License is Elastic-2.0
  • Install the Data Exfiltration Detection assets
  • Verify that no detection rules with the Data Exfiltration tag show up on the Rules Management page under Security
  • Verify that the job IDs have been updated when you click on the Data Exfiltration card under Anomaly Explorer

Related Issues

Not linking since these are internal issues

Screenshots

  • Version shows 2.0 while installing assets
Screen Shot 2023-09-22 at 10 39 39 AM
  • No rules appear upon installing assets
Screen Shot 2023-09-22 at 10 47 16 AM
  • Job IDs have been updated
Screen Shot 2023-09-22 at 10 43 21 AM

@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-05T21:25:14.595+0000

  • Duration: 14 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to ML job and datafeed IDs LGTM.

Copy link
Contributor

@sodhikirti07 sodhikirti07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@ajosh0504 ajosh0504 merged commit aa6d714 into main Oct 12, 2023
4 checks passed
@elasticmachine
Copy link

Package ded - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=ded

@andrewkroh andrewkroh added the Integration:ded Data Exfiltration Detection label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Integration:ded Data Exfiltration Detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants