Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECS] Updating ti_rapid7_threat_command to ECS 8.10 & ECS field validation updates #7949

Merged
merged 3 commits into from
Sep 22, 2023
Merged

[ECS] Updating ti_rapid7_threat_command to ECS 8.10 & ECS field validation updates #7949

merged 3 commits into from
Sep 22, 2023

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Sep 22, 2023

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kgeller kgeller added bug Something isn't working, use only for issues enhancement New feature or request Team:Security-External Integrations Integration:ti_rapid7_threat_command Rapid7 Threat Command labels Sep 22, 2023
@kgeller kgeller self-assigned this Sep 22, 2023
@kgeller kgeller marked this pull request as ready for review September 22, 2023 19:37
@kgeller kgeller requested a review from a team as a code owner September 22, 2023 19:37
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-22T20:12:32.775+0000

  • Duration: 15 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 88.372% (38/43) ❕
Lines 94.245% (868/921) ❕
Conditionals 100.0% (0/0) 💚

@kgeller @taylor-swanson
Update packages/ti_rapid7_threat_command/changelog.yml
2fd034f 
Co-authored-by: Taylor Swanson <90622908+taylor-swanson@users.noreply.github.com>
taylor-swanson
taylor-swanson approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgeller kgeller merged commit 7c7a767 into elastic:main Sep 22, 2023
1 check passed
@kgeller kgeller deleted the tirapid7_ecs8.10_updates branch September 22, 2023 20:28
@elasticmachine
Copy link

Package ti_rapid7_threat_command - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=ti_rapid7_threat_command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees

@kgeller kgeller

Labels
bug Something isn't working, use only for issues enhancement New feature or request Integration:ti_rapid7_threat_command Rapid7 Threat Command
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgeller @elasticmachine @taylor-swanson