Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][STAN] Fix reference error in Channel Overview dashboard #7959

Merged
merged 3 commits into from
Oct 9, 2023
Merged

[O11y][STAN] Fix reference error in Channel Overview dashboard #7959

merged 3 commits into from
Oct 9, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

Description

Channel Overview Metrics Dashboard contains below error.

Could not find reference for kibanaSavedObjectMeta.searchSourceJSON.index

Screenshot

Before Fix

image

After Fix

image

@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-29T04:00:06.700+0000

  • Duration: 20 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 27
Skipped 0
Total 27

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (20/20) 💚 7.266
Lines 95.477% (190/199) 👍 3.835
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 requested a review from a team September 29, 2023 04:07
@rajvi-patel-22 rajvi-patel-22 self-assigned this Sep 29, 2023
@rajvi-patel-22 rajvi-patel-22 added Integration:stan STAN dashboard Relates to a Kibana dashboard bug, enhancement, or modification. bugfix Pull request that fixes a bug issue labels Sep 29, 2023
@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review September 29, 2023 05:31
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner September 29, 2023 05:31
@agithomas agithomas mentioned this pull request Oct 6, 2023
Closed
17 tasks
kush-elastic
kush-elastic approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit 5366772 into elastic:main Oct 9, 2023
1 check passed
@elasticmachine
Copy link

Package stan - 1.3.3 containing this change is available at https://epr.elastic.co/search?package=stan

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@constanca-m constanca-m constanca-m approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

@tetianakravchenko tetianakravchenko Awaiting requested review from tetianakravchenko tetianakravchenko was automatically assigned from elastic/obs-cloudnative-monitoring

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:stan STAN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajvi-patel-22 @elasticmachine @kush-elastic @constanca-m