github: add support for additional audit log fields #7976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
* actor_ip * hashed_token * integration * programmatic_access_type * repositories_added_names * repositories_removed_names * repository_selection * user_agent
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
added descriptions for additional fields
Added field descriptions for new fields
nit edit
| ignore_missing: true | ||
| - rename: | ||
| field: json.user_agent | ||
| target_field: github.user_agent |
There was a problem hiding this comment.
Could be interesting to convert this field into an ECS field using the user_agent processor?
| @@ -122,6 +122,44 @@ processors: | |||
| field: json.actor_location.country_code | |||
| target_field: client.geo.country_iso_code | |||
| ignore_missing: true | |||
| - convert: | |||
| field: json.actor_ip | |||
| target_field: github.actor_ip | |||
There was a problem hiding this comment.
We could populate related_ip with this field.
|
Package github - 1.24.0 containing this change is available at https://epr.elastic.co/search?package=github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add under
github:actor_iphashed_tokenintegrationprogrammatic_access_typerepositories_added_namesrepositories_removed_namesrepository_selectionuser_agentChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots