-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hashicorp_vault] Fix fields.yml definition for dynamic mapping #7978
Merged
andrewkroh
merged 9 commits into
elastic:main
from
andrewkroh:bugfix/hashicorp_vault/fix-dynamic-mappings-metrics
Sep 28, 2023
Merged
[hashicorp_vault] Fix fields.yml definition for dynamic mapping #7978
andrewkroh
merged 9 commits into
elastic:main
from
andrewkroh:bugfix/hashicorp_vault/fix-dynamic-mappings-metrics
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
Team:Security-External Integrations
Integration:hashicorp_vault
Hashicorp Vault
labels
Sep 26, 2023
Earlier versions of Fleet did not handle dynamic mappings correctly so hashicorp_vault explicitly specified the mappings through the manifest. This is no longer needed for 8.x. Fixes elastic#7811
andrewkroh
force-pushed
the
bugfix/hashicorp_vault/fix-dynamic-mappings-metrics
branch
from
September 26, 2023 03:30
774d40e
to
03a266a
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
[git-generate] cd packages/hashicorp_vault elastic-package build
🌐 Coverage report
|
andrewkroh
changed the title
hashicorp_vault - Fix fields.yml definition for dynamic mapping
[hashicorp_vault] Fix fields.yml definition for dynamic mapping
Sep 26, 2023
efd6
reviewed
Sep 26, 2023
efd6
approved these changes
Sep 26, 2023
Package hashicorp_vault - 1.16.1 containing this change is available at https://epr.elastic.co/search?package=hashicorp_vault |
1 similar comment
Package hashicorp_vault - 1.16.1 containing this change is available at https://epr.elastic.co/search?package=hashicorp_vault |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Earlier versions of Fleet did not handle dynamic mappings correctly so hashicorp_vault explicitly specified the mappings through the manifest. This is no longer needed for 8.x. Fixes #7811
Also refer to the ECS definition for all fields that exist in ECS.
Checklist
changelog.yml
file.Related issues
Mappings
This is how the mappings changed.