Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zookeeper] Added dimensions mapping to Zookeeper connection datastream #8059

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Oct 3, 2023

  • Enhancement

What does this PR do?

Added dimension mapping for connection datastream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

  • elastic-package build
  • Mapping tests completed
  • Dashboard tests completed

Related issues

Screenshots

image

@agithomas
Copy link
Contributor Author

agithomas commented Oct 3, 2023

Setings validation
  "time_series": {
    "end_time": "2023-10-03T06:58:23.000Z",
    "start_time": "2023-10-03T02:58:23.000Z"
  },
Mappings verification
      "client": {
        "properties": {
          "ip": {
            "type": "ip",
            "time_series_dimension": true
          },
          "port": {
            "type": "long",
            "time_series_dimension": true
          }
        }
      },
      "service": {
        "properties": {
          "address": {
            "type": "keyword",
            "time_series_dimension": true
          },
          "type": {
            "type": "keyword",
            "ignore_above": 1024
          }
        }
      },
Rollover Testing
GET _index_template/metrics-zookeeper.connection

PUT _index_template/metrics-zookeeper.connection
{
      "index_patterns": [
        "metrics-zookeeper.connection-*"
      ],
      "template": {
        "settings": {
          "index": {
            "mode": null
          }
        }
    },
    "composed_of": [
          "metrics-zookeeper.connection@package",
          "metrics-zookeeper.connection@custom",
          ".fleet_globals-1",
          ".fleet_agent_id_verification-1"
    ],
    "priority": 200,
    "data_stream": {
      "hidden": false,
      "allow_custom_routing": false
    }
}

POST metrics-zookeeper.connection-default/_rollover
{
  "acknowledged": true,
  "shards_acknowledged": true,
  "old_index": ".ds-metrics-zookeeper.connection-default-2023.10.03-000005",
  "new_index": ".ds-metrics-zookeeper.connection-default-2023.10.03-000006",
  "rolled_over": true,
  "dry_run": false,
  "conditions": {}
}

@elasticmachine
Copy link

elasticmachine commented Oct 3, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-03T05:05:46.258+0000

  • Duration: 13 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (6/9) 👎 -26.067
Lines 100.0% (0/0) 💚 8.357
Conditionals 100.0% (0/0) 💚

@agithomas agithomas marked this pull request as ready for review October 3, 2023 05:56
@agithomas agithomas requested a review from a team as a code owner October 3, 2023 05:56
@agithomas agithomas changed the title [Zookeeper] Added dimensions mapping to Zookeeper connections datastream [Zookeeper] Added dimensions mapping to Zookeeper connection datastream Oct 3, 2023
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 727ed61 into elastic:main Oct 11, 2023
1 check passed
@elasticmachine
Copy link

Package zookeeper - 1.8.3 containing this change is available at https://epr.elastic.co/search?package=zookeeper

@agithomas agithomas mentioned this pull request Oct 11, 2023
11 tasks
@andrewkroh andrewkroh added the Integration:zookeeper ZooKeeper Metrics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:zookeeper ZooKeeper Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants