-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add agent input template for the fleet server package #806
Conversation
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
…et-server-agent-template
@@ -38,7 +37,12 @@ policy_templates: | |||
show_user: true | |||
default: | |||
- 8220 | |||
- name: max_connections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and got the following:
data_stream:
namespace: default
server:
port: 8220
host: 0.0.0.0
max_connections: '12'
I wonder why it treats port as an int but max_connections it doesn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Policy looks as following:
- id: 3f0744e7-076c-4a6d-94c7-5a961e50dcf7
name: fleet_server-1
revision: 2
type: fleet-server
use_output: default
meta:
package:
name: fleet_server
version: 0.2.0
data_stream:
namespace: default
server:
max_connections: 45
port: 8220
host: 0.0.0.0
I assume the data_stream part is just filled in by Kibana, at one stage we should probably remove this.
One thing I noticed is that i can put any value into integers fields like |
Description
Resolve #803
Currently we do not send the config from kibana to fleet server as there is not input agent template, we should add one.
This PR fix that by adding an agent template for the fleet server input, I also added the field
max_connections
introduced here elastic/fleet-server#153Agent policy with the template