Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProblemChild] Update files to add Serverless support to the package #8106

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

sodhikirti07
Copy link
Contributor

@sodhikirti07 sodhikirti07 commented Oct 5, 2023

What does this PR do?

This PR adds serverless support to the Living Off the Land advanced analytics package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

  • Follow the steps to spin a Serverless project using elastic-package
  • Make sure the format spec for manifest.yml is 3.0.0
  • Test if all the assets i.e. trained model, ingest pipelines, anomaly detection jobs and detection rules are getting installed successfully.

Screenshots

  • Trained model and ingest pipelines:
    image

image

  • Anomaly detection jobs installed and started:
    image

image

  • Security rules are enabled:
    image

@sodhikirti07 sodhikirti07 added the enhancement New feature or request label Oct 5, 2023
@sodhikirti07 sodhikirti07 requested review from a team as code owners October 5, 2023 15:02
@elasticmachine
Copy link

elasticmachine commented Oct 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-12T17:40:23.394+0000

  • Duration: 15 min 16 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

conditions:
kibana.version: "^8.0.0"
kibana:
version: '^8.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this minimum Stack version compatible with Package Spec v3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with the serverless team and they confirm that we don't require a minimum Kibana version for serverless packages and they'll be based on spec versions.

@qn895
Copy link
Member

qn895 commented Oct 6, 2023

License change LGTM 🎉

Copy link
Contributor

@ajosh0504 ajosh0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sodhikirti07 sodhikirti07 merged commit c1096db into main Oct 13, 2023
4 checks passed
@elasticmachine
Copy link

Package problemchild - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=problemchild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:problemchild Living off the Land Attack Detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants