Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Apache] Migrate Uptime metric visualization to lens #8173

Merged
merged 3 commits into from
Oct 23, 2023
Merged

[O11y][Apache] Migrate Uptime metric visualization to lens #8173

merged 3 commits into from
Oct 23, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

Migrate Uptime metric visualization from Overview dashboard to lens once human readable format ( Seconds / Minutes / Hours ) is available in lens.
image

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Before

image

After

image

@rajvi-patel-22 rajvi-patel-22 self-assigned this Oct 12, 2023
@rajvi-patel-22 rajvi-patel-22 added enhancement New feature or request Integration:apache Apache HTTP Server labels Oct 12, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 12, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-18T13:04:57.756+0000

  • Duration: 18 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 12, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 50.0% (2/4) 👎 -43.75
Classes 50.0% (2/4) 👎 -43.75
Methods 70.0% (28/40) 👎 -16.179
Lines 70.432% (212/301) 👎 -22.649
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review October 12, 2023 09:01
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner October 12, 2023 09:01
milan-elastic
milan-elastic approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

agithomas
agithomas approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit 1e027ba into elastic:main Oct 23, 2023
4 checks passed
@elasticmachine
Copy link

Package apache - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=apache

@shmsr shmsr mentioned this pull request May 8, 2024
Closed
96 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-elastic milan-elastic milan-elastic approved these changes

@agithomas agithomas agithomas approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
enhancement New feature or request Integration:apache Apache HTTP Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][Apache] Migrate Uptime metric visualization to lens
4 participants
@rajvi-patel-22 @elasticmachine @agithomas @milan-elastic