Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imperva] Replace RSA2ELK with Syslog integration for Imperva Securesphere #8237

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

mohitjha-elastic
Copy link
Contributor

@mohitjha-elastic mohitjha-elastic commented Oct 18, 2023

Type of change

  • Enhancement

What does this PR do?

Replace RSA2ELK with Syslog integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Clone integrations repo.
Install elastic package locally.
Start elastic stack using elastic-package.
Move to integrations/packages/imperva directory.
Run the following command to run tests.

Related issues

Automated Test

imperva-test-file.log

@mohitjha-elastic mohitjha-elastic requested a review from a team as a code owner October 18, 2023 13:11
@elasticmachine
Copy link

elasticmachine commented Oct 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-20T11:12:25.001+0000

  • Duration: 18 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Oct 18, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Oct 18, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 4.318
Classes 100.0% (1/1) 💚 4.318
Methods 100.0% (10/10) 💚 8.676
Lines 79.078% (223/282) 👎 -8.437
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only.

packages/imperva/_dev/build/docs/README.md Outdated Show resolved Hide resolved
@efd6
Copy link
Contributor

efd6 commented Oct 20, 2023

/test

@jamiehynds
Copy link

@efd6 would you mind merging this one as Crest don't have the right to do so?

@efd6 efd6 merged commit 95f7a34 into elastic:main Oct 23, 2023
3 checks passed
@elasticmachine
Copy link

Package imperva - 0.19.0 containing this change is available at https://epr.elastic.co/search?package=imperva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imperva Cloud WAF
5 participants