Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zscaler_zia: add question and answer names, and response data to relate.{hosts,ip} #8344

Merged
merged 1 commit into from
Nov 6, 2023
Merged

zscaler_zia: add question and answer names, and response data to relate.{hosts,ip} #8344

merged 1 commit into from
Nov 6, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 31, 2023 •
edited
Loading

Proposed commit message

New test case hand crafted with reference to the Zscaler docs and the package readme.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Oct 31, 2023
@efd6
zscaler_zia: add question and answer names, and response data to rela…
4224162 
…te.{hosts,ip}

New test case hand crafted with reference to the Zscaler docs[1] and the
package readme.

[1]https://help.zscaler.com/zia/nss-feed-output-format-dns-logs
@elasticmachine
Copy link

elasticmachine commented Oct 31, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-31T04:32:04.606+0000

  • Duration: 22 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 100.0% (70/70) 💚 7.692
Lines 93.391% (1625/1740) 👍 1.809
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 5, 2023 21:55
@efd6 efd6 requested a review from a team as a code owner November 5, 2023 21:55
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit dc4663f into elastic:main Nov 6, 2023
4 checks passed
@elasticmachine
Copy link

Package zscaler_zia - 2.17.0 containing this change is available at https://epr.elastic.co/search?package=zscaler_zia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:zscaler_zia Zscaler Internet Access
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Zscaler ZIA] DNS question and answer should be copied into relevant related fields
3 participants
@efd6 @elasticmachine @bhapas