Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloudbeat Azure Credentials config #8376

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Add cloudbeat Azure Credentials config #8376

merged 4 commits into from
Nov 15, 2023

Conversation

moukoublen
Copy link
Member

@moukoublen moukoublen commented Nov 2, 2023 •
edited
Loading

Proposed commit message

Add cloudbeat azure credentials configuration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@moukoublen moukoublen added enhancement New feature or request Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] labels Nov 2, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 2, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-15T08:32:35.014+0000

  • Duration: 16 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 2, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -25.0
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@moukoublen moukoublen force-pushed the cloudbeat_azure_creds_config branch 2 times, most recently from e8d7837 to ac8453a Compare November 6, 2023 08:40
@moukoublen moukoublen marked this pull request as ready for review November 8, 2023 11:09
@moukoublen moukoublen requested a review from a team as a code owner November 8, 2023 11:09
kfirpeled
kfirpeled reviewed Nov 14, 2023
View reviewed changes
packages/cloud_security_posture/data_stream/findings/agent/stream/azure.yml.hbs
azure:
credentials:
{{#if azure.credentials.type}}
type: {{azure.credentials.type}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@moukoublen moukoublen mentioned this pull request Nov 14, 2023
Merged
5 tasks
@moukoublen moukoublen merged commit cc8293c into elastic:main Nov 15, 2023
4 checks passed
@moukoublen moukoublen deleted the cloudbeat_azure_creds_config branch November 15, 2023 12:05
@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview02 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview03 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview04 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview05 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview06 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview07 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview08 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview09 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled left review comments

@oren-zohar oren-zohar oren-zohar approved these changes

@orestisfl orestisfl orestisfl approved these changes

@jeniawhite jeniawhite Awaiting requested review from jeniawhite

@JordanSh JordanSh Awaiting requested review from JordanSh

Assignees

@moukoublen moukoublen

Labels
enhancement New feature or request Integration:cloud_security_posture Security Posture Management Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CIS Azure] Implement CIS Azure authentication methods in integration's hbs manifests
7 participants
@moukoublen @elasticmachine @orestisfl @JordanSh @kfirpeled @oren-zohar @andrewkroh