-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cisco_umbrella] Add system tests for aws-s3 input and fix fields #8388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhapas
force-pushed
the
cisco_umbrella_system_tests
branch
from
November 2, 2023 14:56
59cd654
to
af68b1c
Compare
bhapas
added
Team:Security-External Integrations
Integration:cisco_umbrella
Cisco Umbrella
labels
Nov 2, 2023
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🌐 Coverage report
|
7 tasks
efd6
reviewed
Nov 2, 2023
packages/cisco_umbrella/data_stream/log/_dev/test/system/test-default-config.yml
Show resolved
Hide resolved
bhapas
force-pushed
the
cisco_umbrella_system_tests
branch
from
November 3, 2023 07:36
6420dca
to
587411a
Compare
efd6
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod nit.
packages/cisco_umbrella/data_stream/log/_dev/test/system/test-default-config.yml
Outdated
Show resolved
Hide resolved
/test |
Package cisco_umbrella - 1.20.1 containing this change is available at https://epr.elastic.co/search?package=cisco_umbrella |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See Title
Checklist
- [ ] I have reviewed tips for building integrations and this pull request is aligned with them.- [ ] I have verified that all data streams collect metrics or logs.changelog.yml
file.- [ ] I have verified that Kibana version constraints are current according to guidelines.Related issues
Local testing
Need to add AWS credentials as env variables to be able to test this against AWS instance