o365: prevent API calls having a start time more than 168h in the past #8402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
efd6
force-pushed
the
s4002-o365_cautious
branch
from
5bd699b
to
8f9c94a
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
If an API call takes some time to reach the server, the startTime parameter may have slipped into the time before 168h before now. So reduce our window from 168h to 167h55m to allow leeway for this. Similarly, the allowable interval from start to end time is 24h, and it is possible that the end time now() call is some time after the start time now() call. CEL has no subexpression evaluation order guarantee, so we cannot ensure end is called first by re-ordering the lines. So work around the old behaviour of the now global until the kibana.version for the package is guaranteed to provide an eval-start now value, when we are depending on v8.10.1 (v8.9.1 is also valid, but limiting on that would allow v8.10.0 which does not have the fix).
efd6
force-pushed
the
s4002-o365_cautious
branch
from
8f9c94a
to
f500a4a
Compare
|
Package o365 - 1.25.2 containing this change is available at https://epr.elastic.co/search?package=o365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
If an API call takes some time to reach the server, the startTime parameter may have slipped into the time before 168h before now. So reduce our window from 168h to 167h55m to allow leeway for this.
Similarly, the allowable interval from start to end time is 24h, and it is possible that the end time now() call is some time after the start time now() call. CEL has no subexpression evaluation order guarantee, so we cannot ensure end is called first by re-ordering the lines. So work around the old behaviour of the now global until the kibana.version for the package is guaranteed to provide an eval-start now value, when we are depending on v8.10.1 (v8.9.1 is also valid, but limiting on that would allow v8.10.0 which does not have the fix).
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots