Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloudflare Logpush] Add content-type header to HTTP endpoint setup docs #8446

Conversation

chemamartinez
Copy link
Contributor

Proposed commit message

We have recently received feedback reporting that when configuring the HTTP endpoint for Cloudflare Logpush, incoming HTTP messages may contain an invalid Content-Type header while the HTTP endpoint input expects application/json. It leads to this error:

"error_message": "error 415: error pushing: error uploading to https: 415 {\"message\":\"wrong Content-Type header, expecting application/json\"}",

This pull request defines the Content-Type header when configuring the destination for the HTTP endpoint in the setup guide.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chemamartinez chemamartinez added Team:Security-External Integrations Integration:cloudflare_logpush Cloudflare Logpush bugfix Pull request that fixes a bug issue labels Nov 9, 2023
@chemamartinez chemamartinez self-assigned this Nov 9, 2023
@chemamartinez chemamartinez marked this pull request as ready for review November 9, 2023 12:07
@chemamartinez chemamartinez requested a review from a team as a code owner November 9, 2023 12:07
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Nov 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-13T09:06:34.840+0000

  • Duration: 30 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 115
Skipped 0
Total 115

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 9, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (18/18) 💚
Files 100.0% (18/18) 💚 3.86
Classes 100.0% (18/18) 💚 3.86
Methods 100.0% (215/215) 💚 7.804
Lines 91.959% (4883/5310) 👍 3.347
Conditionals 100.0% (0/0) 💚

@chemamartinez chemamartinez force-pushed the cloudflare_logpush-http-endpoint-header-docs branch from 8400a10 to f2f80a7 Compare November 10, 2023 11:55
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemamartinez
Copy link
Contributor Author

/test

1 similar comment
@chemamartinez
Copy link
Contributor Author

/test

@chemamartinez chemamartinez merged commit 34242b3 into elastic:main Nov 13, 2023
4 checks passed
@elasticmachine
Copy link

Package cloudflare_logpush - 1.17.1 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:cloudflare_logpush Cloudflare Logpush
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CloudFlare Logpush Documentation
3 participants