Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure] [app_insights] Rename dimensions fingerprint field #8454

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Nov 9, 2023

Overview

Renamed the dimensions fingerprint field in app insights data stream to prevent it from being nested within azure.dimensions field.

Since azure.dimensions is of type flattened, the field cannot be a dimension if it is nested within it.

Renaming it to something like azure.dimensions_fingerprint fixes this.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 self-assigned this Nov 9, 2023
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-09T20:42:55.534+0000

  • Duration: 16 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.79
Classes 100.0% (0/0) 💚 3.79
Methods 57.143% (4/7) 👎 -35.205
Lines 100.0% (0/0) 💚 11.267
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review November 9, 2023 21:26
@gpop63 gpop63 requested a review from a team as a code owner November 9, 2023 21:26
@mrodm mrodm mentioned this pull request Nov 10, 2023
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gpop63 gpop63 merged commit de067e9 into elastic:main Dec 4, 2023
4 checks passed
@elasticmachine
Copy link

Package azure_application_insights - 1.2.3 containing this change is available at https://epr.elastic.co/search?package=azure_application_insights

@andrewkroh andrewkroh added the Integration:azure_application_insights Azure Application Insights Metrics Overview label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:azure_application_insights Azure Application Insights Metrics Overview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants