Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 24h period configuration to all CSPM providers #8516

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Add 24h period configuration to all CSPM providers #8516

merged 2 commits into from
Nov 15, 2023

Conversation

romulets
Copy link
Member

@romulets romulets commented Nov 15, 2023 •
edited
Loading

Why

As mentioned on elastic/cloudbeat#1478 currently only CSPM AWS runs on a 24h cycle, GCP and Azure run on a 4h cycle (default value), while all CSPM should run on a 24h period.

What

Add 24h period configuration to all CSPMs. AWS already had, added to GCP and Azure.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • All CSPM have 24h period configured

Related issues

@romulets romulets added the bug Something isn't working, use only for issues label Nov 15, 2023
@romulets romulets self-assigned this Nov 15, 2023
@romulets romulets requested a review from a team as a code owner November 15, 2023 11:58
@romulets romulets changed the title Add 24h period configuration toall CSPM providers Add 24h period configuration to all CSPM providers Nov 15, 2023
oren-zohar
oren-zohar requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please verify these changes locally?

packages/cloud_security_posture/changelog.yml Outdated Show resolved Hide resolved
packages/cloud_security_posture/manifest.yml Outdated Show resolved Hide resolved
@elasticmachine
Copy link

elasticmachine commented Nov 15, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-15T13:30:10.819+0000

  • Duration: 15 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 15, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

oren-zohar
oren-zohar approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@romulets romulets merged commit f1b08dd into elastic:main Nov 15, 2023
4 checks passed
romulets added a commit that referenced this pull request Nov 15, 2023
@romulets
Revert "Add 24h period configuration to all CSPM providers (#8516)"
d3f9fec 
This reverts commit f1b08dd.
@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview03 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview04 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview05 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview06 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview07 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview08 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview09 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oren-zohar oren-zohar oren-zohar approved these changes

@jeniawhite jeniawhite jeniawhite approved these changes

Assignees

@romulets romulets

Labels
bug Something isn't working, use only for issues Integration:cloud_security_posture Security Posture Management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Every CSPM provider should run with 24 hour cycles
5 participants
@romulets @elasticmachine @jeniawhite @oren-zohar @andrewkroh