cisco_umbrella: don't clobber temporary field when collecting identities #8535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Previously, the
cisco.umbrella._tmp
field was unconditionally being assigned a new hash map whencisco.umbrella.identity
contained multiple identities, deleting already collected information including the@timestamp
. Fix this by making the map construction conditional.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots