Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_umbrella: don't clobber temporary field when collecting identities #8535

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 19, 2023

Proposed commit message

Previously, the cisco.umbrella._tmp field was unconditionally being assigned a new hash map when cisco.umbrella.identity contained multiple identities, deleting already collected information including the @timestamp. Fix this by making the map construction conditional.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cisco_umbrella Cisco Umbrella labels Nov 19, 2023
@efd6 efd6 self-assigned this Nov 19, 2023
@efd6
Copy link
Contributor Author

efd6 commented Nov 20, 2023

/test

Previously, the cisco.umbrella._tmp field was unconditionally being
assigned a new hash map when cisco.umbrella.identity contained multiple
identities, deleting already collected information including the
@timestamp. Fix this by making the map construction conditional.
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-20T01:14:34.039+0000

  • Duration: 24 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (21/21) 💚 50.0
Lines 95.027% (535/563) 👎 -4.973
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 20, 2023 02:25
@efd6 efd6 requested a review from a team as a code owner November 20, 2023 02:25
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 736db28 into elastic:main Nov 21, 2023
4 checks passed
@elasticmachine
Copy link

Package cisco_umbrella - 1.21.1 containing this change is available at https://epr.elastic.co/search?package=cisco_umbrella

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cisco_umbrella Cisco Umbrella
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Pipeline used within Cisco Umbrella Integration - timestamp not mapped correctly
3 participants