Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network.forwarded_ip datatype in ingest pipeline #8541

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

muthu-mps
Copy link
Contributor

@muthu-mps muthu-mps commented Nov 20, 2023

  • Bug

Proposed commit message

The datatype for network.forwarded_ip field is set to IPORHOST in the ingest pipeline processor. The datatype should be of type IP

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

@muthu-mps muthu-mps self-assigned this Nov 20, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-23T03:31:52.680+0000

  • Duration: 15 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 86.111% (31/36)
Lines 96.143% (349/363)
Conditionals 100.0% (0/0) 💚

@muthu-mps muthu-mps marked this pull request as ready for review November 20, 2023 12:21
@muthu-mps muthu-mps requested a review from a team as a code owner November 20, 2023 12:21
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muthu-mps muthu-mps merged commit 063567d into elastic:main Nov 27, 2023
4 checks passed
@elasticmachine
Copy link

Package iis - 1.17.2 containing this change is available at https://epr.elastic.co/search?package=iis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IIS] - IPORHOST grok pattern for network-forwarder is set incorrectly
5 participants