-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt secrets in Cloud Security Posture #8665
Conversation
dadb9cf
to
43c4e74
Compare
/test |
🌐 Coverage report
|
Package cloud_security_posture - 1.8.0-preview01 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.8.0-preview02 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.8.0-preview03 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.8.0-preview04 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.8.0-preview05 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.8.0-preview06 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.8.0-preview07 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.8.0-preview08 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
What
Adopt Secrets in Cloud Posture Management. A similar PR was created before, but reverted to not impact 8.12 release. This PR applies the changes to 1.8.0, therefore 8.13
This issue suggests potential secrets in cloud_secruity_posture. The following fields where labeled as secrets
cloudbeat/cis_eks
session_token
cloudbeat/cis_aws
secret_access_key
cloudbeat/cis_azure
azure.credentials.client_secret
azure.credentials.client_password
azure.credentials.client_certificate_password
Based on the criteria used of what potentially is a secret, more fields would have been classified as secret. Below you can find why they were not:
session_token
: amazon doesn't consider it a secret, it's something temporary (@jeniawhite confirmed)access_key_id
: this always comes in pair withsecret_access_key
. I considered only the secret, a secret. The access key is plain text in AWS and in our integration page anyway. I believe onlysecret_access_key
should be a secret.Why
Adoption of secrets is a kibana wide effort to remove the possibility of secrets leaks in kibana (via system logs/audit or humans)
Checklist
changelog.yml
file.Author's Checklist
Related issues
Screenshots
Example of stored secret: