Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt secrets in Cloud Security Posture #8665

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

romulets
Copy link
Member

@romulets romulets commented Dec 7, 2023

What

Adopt Secrets in Cloud Posture Management. A similar PR was created before, but reverted to not impact 8.12 release. This PR applies the changes to 1.8.0, therefore 8.13

This issue suggests potential secrets in cloud_secruity_posture. The following fields where labeled as secrets

  • cloudbeat/cis_eks
    • session_token
  • cloudbeat/cis_aws
    • secret_access_key
  • cloudbeat/cis_azure
    • azure.credentials.client_secret
    • azure.credentials.client_password
    • azure.credentials.client_certificate_password

Based on the criteria used of what potentially is a secret, more fields would have been classified as secret. Below you can find why they were not:

  • session_token: amazon doesn't consider it a secret, it's something temporary (@jeniawhite confirmed)
  • access_key_id: this always comes in pair with secret_access_key . I considered only the secret, a secret. The access key is plain text in AWS and in our integration page anyway. I believe only secret_access_key should be a secret.

Why

Adoption of secrets is a kibana wide effort to remove the possibility of secrets leaks in kibana (via system logs/audit or humans)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Test all integrations with secrets and validate that Posture Management still properly works
  • Test create, update and upgrade flow

Related issues

Screenshots

Example of stored secret:

ezgif com-video-to-gif

@romulets romulets added the enhancement New feature or request label Dec 7, 2023
@romulets romulets requested a review from a team as a code owner December 7, 2023 09:39
@elasticmachine
Copy link

elasticmachine commented Dec 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-12T10:11:29.117+0000

  • Duration: 15 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@romulets
Copy link
Member Author

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 5.556
Classes 100.0% (0/0) 💚 5.556
Methods 25.0% (2/8) 👎 -69.969
Lines 100.0% (0/0) 💚 12.295
Conditionals 100.0% (0/0) 💚

@romulets romulets merged commit 2d2af76 into elastic:main Dec 12, 2023
4 checks passed
@elasticmachine
Copy link

Package cloud_security_posture - 1.8.0-preview01 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.8.0-preview02 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.8.0-preview03 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.8.0-preview04 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.8.0-preview05 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.8.0-preview06 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.8.0-preview07 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.8.0-preview08 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:cloud_security_posture Security Posture Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants