Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trendmicro] Add better ECS categorization for event.type and event.category #8681

Merged
merged 4 commits into from
Dec 11, 2023
Merged

[trendmicro] Add better ECS categorization for event.type and event.category #8681

merged 4 commits into from
Dec 11, 2023

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Dec 8, 2023 •
edited
Loading

Proposed commit message

The trendmicro integration had very general and conflicting ECS categorization values for event.category and event.type respectively. This updates them to be more specific.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@kgeller kgeller added the bug Something isn't working, use only for issues label Dec 8, 2023
@kgeller kgeller self-assigned this Dec 8, 2023
@elasticmachine
Copy link

elasticmachine commented Dec 8, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-11T14:26:39.210+0000

  • Duration: 17 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 8, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 22.222% (2/9) ❕
Classes 22.222% (2/9) ❕
Methods 31.818% (14/44) ❕
Lines 20.445% (101/494) ❕
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@kgeller kgeller marked this pull request as ready for review December 8, 2023 21:17
@kgeller kgeller requested a review from a team as a code owner December 8, 2023 21:17
kcreddy
kcreddy approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 . Minor suggestion

packages/trendmicro/data_stream/deep_security/elasticsearch/ingest_pipeline/web-reputation.yml Outdated Show resolved Hide resolved
@kcreddy kcreddy added the Integration:trendmicro Trend Micro Deep Security label Dec 9, 2023
@kgeller kgeller merged commit 6fd85ae into elastic:main Dec 11, 2023
4 checks passed
@kgeller kgeller deleted the trendmicro-event-type-updates branch December 11, 2023 14:47
@elasticmachine
Copy link

Package trendmicro - 1.8.3 containing this change is available at https://epr.elastic.co/search?package=trendmicro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@kgeller kgeller

Labels
bug Something isn't working, use only for issues Integration:trendmicro Trend Micro Deep Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kgeller @elasticmachine @andrewkroh @kcreddy