Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a few data streams to enabled in the linux integration #883

Merged
merged 5 commits into from
Apr 6, 2021
Merged

Set a few data streams to enabled in the linux integration #883

merged 5 commits into from
Apr 6, 2021

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Apr 5, 2021 •
edited
Loading

What does this PR do?

Right now, all the data streams in linux are disabled by default, which can be a tad confusing when a user clicks the slider to enable the data stream groups, and Kibana just enables all of the data streams, even when some streams like raid require a specific system config. This enables a few basic data streams, so uses get some data streams by default, and so they won't blindly enable the entire integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

  • Pull down, build, start stack
  • Add the linux integration in the Kibana UI, make sure the data stream groups are on by default.

@fearful-symmetry fearful-symmetry added the bug Something isn't working, use only for issues label Apr 5, 2021
@fearful-symmetry fearful-symmetry requested a review from a team April 5, 2021 20:09
@fearful-symmetry fearful-symmetry self-assigned this Apr 5, 2021
@elasticmachine
Copy link

elasticmachine commented Apr 5, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #883 updated

  • Start Time: 2021-04-06T18:01:01.255+0000

  • Duration: 14 min 57 sec

  • Commit: a27a16e

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

Trends 🧪

Image of Build Times

Image of Tests

jsoriano
jsoriano reviewed Apr 6, 2021
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍, please update the description in the changelog.

packages/linux/changelog.yml Outdated Show resolved Hide resolved
@fearful-symmetry fearful-symmetry requested review from jsoriano and a team April 6, 2021 16:42
@fearful-symmetry fearful-symmetry merged commit 7ea4327 into elastic:master Apr 6, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@fearful-symmetry
Set a few data streams to enabled in the linux integration (elastic#883)
09ecb4c 
* set a few data streams to enabled

* update version

* add changelog

* fix changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@fearful-symmetry fearful-symmetry

Labels
bug Something isn't working, use only for issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fearful-symmetry @elasticmachine @jsoriano