[windows] Adding custom config to datastreams winlog input #8877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
approved these changes
Jan 12, 2024
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
efd6
reviewed
Jan 14, 2024
| @@ -29,3 +29,4 @@ processors: | |||
| {{#if processors.length}} | |||
| {{processors}} | |||
| {{/if}} | |||
| {{custom}} | |||
There was a problem hiding this comment.
Final new lines where missing?
There was a problem hiding this comment.
I guess so?
All I did was manually drop the {{custom}} on the last line of the files to match what we do in winlog (https://github.com/kgeller/integrations/blob/main/packages/winlog/agent/input/winlog.yml.hbs#L32)
💚 Build Succeeded
cc @kgeller |
|
Package windows - 1.44.0 containing this change is available at https://epr.elastic.co/search?package=windows |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Adding the ability for users to set custom yaml config for windows datastream winlog inputs.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots