Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][ActiveMQ] Update README #8926

Merged
merged 12 commits into from
Jan 24, 2024
Merged

[O11y][ActiveMQ] Update README #8926

merged 12 commits into from
Jan 24, 2024

Conversation

harnish-elastic
Copy link
Contributor

Proposed commit message

  • Update README with more details of ActiveMQ and all the data streams that supported.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.

Related issues

@harnish-elastic harnish-elastic added documentation Improvements or additions to documentation enhancement New feature or request Integration:activemq ActiveMQ labels Jan 18, 2024
@harnish-elastic harnish-elastic self-assigned this Jan 18, 2024
@harnish-elastic harnish-elastic requested a review from a team as a code owner January 18, 2024 08:19
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

alaudazzi
alaudazzi approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few editing suggestions, otherwise LGTM.

packages/activemq/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/activemq/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/activemq/docs/README.md Outdated Show resolved Hide resolved
packages/activemq/docs/README.md Outdated Show resolved Hide resolved
harnish-elastic and others added 5 commits January 19, 2024 13:34
@harnish-elastic @alaudazzi
Update packages/activemq/_dev/build/docs/README.md
18fbecd 
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
@harnish-elastic @alaudazzi
Update packages/activemq/_dev/build/docs/README.md
48d6e53 
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
@harnish-elastic @alaudazzi
Update packages/activemq/docs/README.md
cbadbe8 
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
@harnish-elastic @alaudazzi
Update packages/activemq/docs/README.md
ed1ab4b 
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
@harnish-elastic
elastic-package check
a4ef181
ali786XI
ali786XI approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
1ace0e0 
…into activemq-update-readme

Conflicts:
	packages/activemq/changelog.yml
@harnish-elastic
version bump up
bd920ad
muthu-mps
muthu-mps reviewed Jan 22, 2024
View reviewed changes
packages/activemq/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/activemq/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/activemq/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/activemq/changelog.yml Outdated Show resolved Hide resolved
harnish-elastic and others added 3 commits January 22, 2024 17:38
@harnish-elastic @muthu-mps
Update packages/activemq/changelog.yml
1e8f20c 
Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
@harnish-elastic @muthu-mps
Update packages/activemq/_dev/build/docs/README.md
10eb9f1 
Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
@harnish-elastic
address review comments
37a0434
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @harnish-elastic

muthu-mps
muthu-mps approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic harnish-elastic merged commit 34a01d5 into elastic:main Jan 24, 2024
3 checks passed
@elasticmachine
Copy link

Package activemq - 0.16.0 containing this change is available at https://epr.elastic.co/search?package=activemq

@harnish-elastic harnish-elastic mentioned this pull request Feb 1, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ali786XI ali786XI ali786XI approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

@alaudazzi alaudazzi alaudazzi approved these changes

Assignees

@harnish-elastic harnish-elastic

Labels
documentation Improvements or additions to documentation enhancement New feature or request Integration:activemq ActiveMQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][ActiveMQ] Update README
5 participants
@harnish-elastic @elasticmachine @alaudazzi @muthu-mps @ali786XI