Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][ActiveMQ] Add metric_type and support tooltip for period #8928

Merged
merged 7 commits into from
Jan 22, 2024
Merged

[O11y][ActiveMQ] Add metric_type and support tooltip for period #8928

merged 7 commits into from
Jan 22, 2024

Conversation

harnish-elastic
Copy link
Contributor

Proposed commit message

  • Add metric_type to the fields that doesn't having it.
  • Support tooltip for period.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

@harnish-elastic harnish-elastic added enhancement New feature or request Integration:activemq ActiveMQ labels Jan 18, 2024
@harnish-elastic harnish-elastic self-assigned this Jan 18, 2024
@harnish-elastic harnish-elastic requested a review from a team as a code owner January 18, 2024 09:56
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

milan-elastic
milan-elastic approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ritalwar
ritalwar reviewed Jan 19, 2024
View reviewed changes
packages/activemq/changelog.yml Outdated Show resolved Hide resolved
packages/activemq/data_stream/broker/manifest.yml Outdated Show resolved Hide resolved
packages/activemq/data_stream/queue/manifest.yml Outdated Show resolved Hide resolved
packages/activemq/data_stream/topic/manifest.yml Outdated Show resolved Hide resolved
harnish-elastic and others added 4 commits January 19, 2024 16:25
@harnish-elastic @ritalwar
Update packages/activemq/data_stream/broker/manifest.yml
4f17c43 
Co-authored-by: Richa Talwar <102972658+ritalwar@users.noreply.github.com>
@harnish-elastic @ritalwar
Update packages/activemq/data_stream/queue/manifest.yml
6f9204c 
Co-authored-by: Richa Talwar <102972658+ritalwar@users.noreply.github.com>
@harnish-elastic @ritalwar
Update packages/activemq/data_stream/topic/manifest.yml
83023f0 
Co-authored-by: Richa Talwar <102972658+ritalwar@users.noreply.github.com>
@harnish-elastic
update changelog
a8e0b0a
@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
a275a69 
…into activemq-add-metric-type-and-tooltip

Conflicts:
	packages/activemq/changelog.yml
	packages/activemq/manifest.yml
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @harnish-elastic

@harnish-elastic harnish-elastic merged commit 81cd546 into elastic:main Jan 22, 2024
3 checks passed
@elasticmachine
Copy link

Package activemq - 0.15.0 containing this change is available at https://epr.elastic.co/search?package=activemq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-elastic milan-elastic milan-elastic approved these changes

@ritalwar ritalwar ritalwar approved these changes

Assignees

@harnish-elastic harnish-elastic

Labels
enhancement New feature or request Integration:activemq ActiveMQ
Projects
None yet
Milestone
No milestone
4 participants
@harnish-elastic @elasticmachine @ritalwar @milan-elastic