Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lastpass: conditional field access and grok cleanup #9002

Merged
merged 3 commits into from
Jan 30, 2024
Merged

lastpass: conditional field access and grok cleanup #9002

merged 3 commits into from
Jan 30, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 30, 2024 •
edited
Loading

Proposed commit message

Make conditional field accesses safe for method calls and clean up grok expressions to reduce escape spam.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added Integration:lastpass LastPass bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Jan 30, 2024
@efd6 efd6 self-assigned this Jan 30, 2024
@efd6 efd6 mentioned this pull request Jan 30, 2024
Open
39 tasks
@elasticmachine
Copy link

elasticmachine commented Jan 30, 2024 •
edited
Loading

🚀 Benchmarks report

Package lastpass 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
user 4464.29 3472.22 -992.07 (-22.22%) 💔

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review January 30, 2024 02:52
@efd6 efd6 requested a review from a team as a code owner January 30, 2024 02:52
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #8450 succeeded b58b88848c189ba4dad0873224c490da4487b393

cc @efd6

ShourieG
ShourieG approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit a253de3 into elastic:main Jan 30, 2024
3 checks passed
@elasticmachine
Copy link

Package lastpass - 1.14.2 containing this change is available at https://epr.elastic.co/search?package=lastpass

1 similar comment
@elasticmachine
Copy link

Package lastpass - 1.14.2 containing this change is available at https://epr.elastic.co/search?package=lastpass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

Assignees

@efd6 efd6

Labels
bugfix Pull request that fixes a bug issue Integration:lastpass LastPass Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @ShourieG