Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][PHP-FPM] Update README to use documentation guidelines #9069

Merged
merged 7 commits into from
Feb 13, 2024
Merged

[O11y][PHP-FPM] Update README to use documentation guidelines #9069

merged 7 commits into from
Feb 13, 2024

Conversation

harnish-elastic
Copy link
Contributor

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@harnish-elastic harnish-elastic added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 6, 2024
@harnish-elastic harnish-elastic self-assigned this Feb 6, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@harnish-elastic harnish-elastic marked this pull request as ready for review February 7, 2024 04:57
@harnish-elastic harnish-elastic requested a review from a team as a code owner February 7, 2024 04:57
niraj-elastic
niraj-elastic approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@niraj-elastic niraj-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided a ingle nit, everything else seems good.

packages/php_fpm/changelog.yml Outdated Show resolved Hide resolved
alaudazzi
alaudazzi requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments are integrated.

packages/php_fpm/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/php_fpm/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/php_fpm/_dev/build/docs/README.md Outdated Show resolved Hide resolved
alaudazzi
alaudazzi approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devamanv
devamanv reviewed Feb 9, 2024
View reviewed changes
packages/php_fpm/docs/README.md Outdated Show resolved Hide resolved
packages/php_fpm/docs/README.md Show resolved Hide resolved
packages/php_fpm/docs/README.md Outdated Show resolved Hide resolved
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @harnish-elastic

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

devamanv
devamanv approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic harnish-elastic merged commit 30f3c8d into elastic:main Feb 13, 2024
5 checks passed
@elasticmachine
Copy link

Package php_fpm - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=php_fpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niraj-elastic niraj-elastic niraj-elastic approved these changes

@alaudazzi alaudazzi alaudazzi approved these changes

@devamanv devamanv devamanv approved these changes

Assignees

@harnish-elastic harnish-elastic

Labels
documentation Improvements or additions to documentation enhancement New feature or request Integration:php_fpm PHP-FPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply the Integrations doc template to PHP-FPM
6 participants
@harnish-elastic @elasticmachine @devamanv @alaudazzi @niraj-elastic @andrewkroh