Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set sensitive values as secret - Part 2 #9127

Merged
merged 2 commits into from Feb 22, 2024
Merged

Set sensitive values as secret - Part 2 #9127

merged 2 commits into from Feb 22, 2024

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Feb 12, 2024 •
edited

Proposed commit message

  • Set sensitive values as secret in integrations.
  • Updated package-spec to 3.0.2 in most packages to leverage secrets validation checks.
  • Certain packages required fixes to mappings (due to missing or incorrect mappings).
  • Certain packages were not able to go to package-spec 3.0.2 due issues with dynamic mappings. These have been held back at 3.0.0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

  • Relates elastic/security-team#7388

@taylor-swanson taylor-swanson self-assigned this Feb 12, 2024
@taylor-swanson taylor-swanson added enhancement New feature or request Team:Service-Integrations Label for the Service Integrations team Team:Security-Service Integrations Security Service Integrations Team and removed Team:Service-Integrations Label for the Service Integrations team labels Feb 12, 2024
@elasticmachine
Copy link

elasticmachine commented Feb 12, 2024 •
edited

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@taylor-swanson taylor-swanson marked this pull request as ready for review February 12, 2024 17:31
@taylor-swanson taylor-swanson requested a review from a team as a code owner February 12, 2024 17:31
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

packages/mimecast/manifest.yml Show resolved Hide resolved
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@taylor-swanson taylor-swanson merged commit a01bfc6 into elastic:main Feb 22, 2024
5 checks passed
@taylor-swanson taylor-swanson deleted the feature/secret-values-svc-2 branch February 22, 2024 17:53
@elasticmachine
Copy link

Package darktrace - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=darktrace

@elasticmachine
Copy link

Package entityanalytics_entra_id - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=entityanalytics_entra_id

@elasticmachine
Copy link

Package entityanalytics_okta - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=entityanalytics_okta

@elasticmachine
Copy link

Package f5_bigip - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=f5_bigip

@elasticmachine
Copy link

Package forgerock - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=forgerock

@elasticmachine
Copy link

Package gcp_pubsub - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=gcp_pubsub

@elasticmachine
Copy link

Package github - 1.28.0 containing this change is available at https://epr.elastic.co/search?package=github

@elasticmachine
Copy link

Package google_cloud_storage - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=google_cloud_storage

@elasticmachine
Copy link

Package google_scc - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=google_scc

@elasticmachine
Copy link

Package google_workspace - 2.20.0 containing this change is available at https://epr.elastic.co/search?package=google_workspace

@elasticmachine
Copy link

Package http_endpoint - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=http_endpoint

@elasticmachine
Copy link

Package httpjson - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=httpjson

@elasticmachine
Copy link

Package infoblox_bloxone_ddi - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi

@elasticmachine
Copy link

Package jumpcloud - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=jumpcloud

@elasticmachine
Copy link

Package lastpass - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=lastpass

@elasticmachine
Copy link

Package lyve_cloud - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=lyve_cloud

@elasticmachine
Copy link

Package m365_defender - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=m365_defender

@elasticmachine
Copy link

Package microsoft_defender_cloud - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_defender_cloud

@elasticmachine
Copy link

Package microsoft_defender_endpoint - 2.24.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_defender_endpoint

@elasticmachine
Copy link

Package microsoft_exchange_online_message_trace - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_exchange_online_message_trace

@elasticmachine
Copy link

Package mimecast - 1.23.0 containing this change is available at https://epr.elastic.co/search?package=mimecast

gizas pushed a commit that referenced this pull request Mar 13, 2024
@taylor-swanson @gizas
Set sensitive values as secret - Part 2 (#9127)
cc6bd03 
- Set sensitive values as secret in integrations.
- Updated package-spec to 3.0.2 in most packages to leverage secrets validation checks.
- Certain packages required fixes to mappings (due to missing or incorrect mappings).
- Certain packages were not able to go to package-spec 3.0.2 due to issues with dynamic mappings. These have been held back at 3.0.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
enhancement New feature or request Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taylor-swanson @elasticmachine @kcreddy