[ti_cif3] Clean up null handling

[chrisberkhout]

Proposed commit message

[ti_cif3] Clean up null handling (#)

- Remove redundant null-safe access to ctx.
- Make access after null-safe access also be null-safe.
- Combine 'not null and is/not value' checks.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

Related issues

• Relates Incorrect null handling in if conditions and elsewhere #8646

[chrisberkhout]

/test

[elasticmachine]

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

[efd6]

I'm wondering if in the cases where the field checks are obviously cheaper, they should not go first to avoid the futile array allocation for the Array.contains call. The case here and below are clear since it's a null check; the case above with a string compare may be less obvious, but also may benefit since a small string compare should be cheaper than an alloc.

[chrisberkhout]

I did the case above in its own commit.

I did this case and below in a separate commit. These ones I'm ambivalent about because while it makes sense for performance, I think readability is better with the repeated condition first and the differentiating condition following.

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 2109ab2

History

• 💚 Build #8953 succeeded 48bbb56
• 💔 Build #8948 failed 5be8fd406215cff441c7631c1eb2765e49e23f4c
• 💔 Build #8943 failed 5be8fd406215cff441c7631c1eb2765e49e23f4c

cc @chrisberkhout

[elastic-sonarqube]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
13.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[elasticmachine]

Package ti_cif3 - 1.10.2 containing this change is available at https://epr.elastic.co/search?package=ti_cif3