Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github] Clean up null handling, formatting #9181

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

chrisberkhout
Copy link
Contributor

Proposed commit message

[github] Clean up null handling, formatting (#)

- Remove redundant null-safe operator.
- Make access after null-safe access also be null-safe.
- Make nullable checks boolean.
- Remove redundant quotes.
- Combine 'is null or not contains' checks.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout added Integration:github GitHub Team:Service-Integrations Label for the Service Integrations team bugfix Pull request that fixes a bug issue labels Feb 15, 2024
@chrisberkhout chrisberkhout self-assigned this Feb 15, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner February 15, 2024 18:24
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

Copy link

Quality Gate failed Quality Gate failed

Failed conditions

62.5% 62.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@chrisberkhout chrisberkhout merged commit 9e9dc71 into elastic:main Feb 22, 2024
4 of 5 checks passed
@chrisberkhout chrisberkhout deleted the github-null-handling branch February 22, 2024 06:49
@elasticmachine
Copy link

Package github - 1.27.3 containing this change is available at https://epr.elastic.co/search?package=github

gizas pushed a commit that referenced this pull request Mar 13, 2024
- Remove redundant null-safe operator.
- Make access after null-safe access also be null-safe.
- Make nullable checks boolean.
- Remove redundant quotes.
- Combine 'is null or not contains' checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:github GitHub Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants