-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[github] Clean up null handling, formatting #9181
Merged
chrisberkhout
merged 3 commits into
elastic:main
from
chrisberkhout:github-null-handling
Feb 22, 2024
Merged
[github] Clean up null handling, formatting #9181
chrisberkhout
merged 3 commits into
elastic:main
from
chrisberkhout:github-null-handling
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisberkhout
added
Integration:github
GitHub
Team:Service-Integrations
Label for the Service Integrations team
bugfix
Pull request that fixes a bug issue
labels
Feb 15, 2024
39 tasks
🚀 Benchmarks reportTo see the full report comment with |
efd6
reviewed
Feb 18, 2024
packages/github/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/github/data_stream/code_scanning/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
4 tasks
💚 Build Succeeded
History
|
Quality Gate failedFailed conditions62.5% Coverage on New Code (required ≥ 80%) |
efd6
approved these changes
Feb 21, 2024
Package github - 1.27.3 containing this change is available at https://epr.elastic.co/search?package=github |
gizas
pushed a commit
that referenced
this pull request
Mar 13, 2024
- Remove redundant null-safe operator. - Make access after null-safe access also be null-safe. - Make nullable checks boolean. - Remove redundant quotes. - Combine 'is null or not contains' checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Pull request that fixes a bug issue
Integration:github
GitHub
Team:Service-Integrations
Label for the Service Integrations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.yml
file.Related issues
null
handling inif
conditions and elsewhere #8646