Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carbon Black Cloud] - Introduced data stream specific SQS queues #9303

Merged
merged 14 commits into from
Mar 7, 2024

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Mar 7, 2024

Type of change

  • Bug
  • Enhancement

Proposed commit message

Introduced data stream specific SQS queues to address the issue of data loss while using a single SQS queue for all data streams and then filtering out data using file selectors. The filtering using file selectors in a particular data stream caused the data for other data streams to get dropped by the SQS queue as described in this issue: #9289. This PR introduces an optional SQS queue per data stream while still keeping support for the original global SQS queue. The data stream specific queues will always override the global queues. The default file selector regexes have been commented out. This approach was adopted instead of just outright removing the older queues and file selectors was to maintain compatibility with the previous versions and not cause a breaking change. The updated setup instructions and update warnings have been documented to make the end user aware of the new functionality.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Test Results

--- Test results for package: carbon_black_cloud - START ---
╭────────────────────┬─────────────────────────────┬───────────┬───────────┬────────┬───────────────╮
│ PACKAGE            │ DATA STREAM                 │ TEST TYPE │ TEST NAME │ RESULT │  TIME ELAPSED │
├────────────────────┼─────────────────────────────┼───────────┼───────────┼────────┼───────────────┤
│ carbon_black_cloud │ alert                       │ system    │ default   │ PASS   │ 48.086184125s │
│ carbon_black_cloud │ asset_vulnerability_summary │ system    │ default   │ PASS   │    30.544891s │
│ carbon_black_cloud │ audit                       │ system    │ default   │ PASS   │ 31.415609833s │
╰────────────────────┴─────────────────────────────┴───────────┴───────────┴────────┴───────────────╯
--- Test results for package: carbon_black_cloud - END   ---

Screenshots

@ShourieG ShourieG requested a review from a team as a code owner March 7, 2024 14:03
@ShourieG ShourieG self-assigned this Mar 7, 2024
@ShourieG ShourieG added bugfix Pull request that fixes a bug issue enhancement New feature or request integration Label used for meta issues tracking each integration Team:Service-Integrations Label for the Service Integrations team labels Mar 7, 2024
@narph narph added Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] and removed Team:Service-Integrations Label for the Service Integrations team labels Mar 7, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Rest LGTM 👍🏼

packages/carbon_black_cloud/_dev/build/docs/README.md Outdated Show resolved Hide resolved
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @ShourieG

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ShourieG ShourieG merged commit b8da31e into elastic:main Mar 7, 2024
5 checks passed
@ShourieG ShourieG deleted the bugfix/carbon_black branch March 7, 2024 14:33
@elasticmachine
Copy link

Package carbon_black_cloud - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=carbon_black_cloud

@elasticmachine
Copy link

Package carbon_black_cloud - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=carbon_black_cloud

gizas pushed a commit that referenced this pull request Mar 13, 2024
)

* refactored the integration, added new parameters and improved documentation for making integration GA

* Fixed data loss issue by providing option for data stream specific  SQS queues, updated docs accordingly

* updated changelog

* updated docs as per PR suggestions
@andrewkroh andrewkroh added the Integration:carbon_black_cloud VMware Carbon Black Cloud label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:carbon_black_cloud VMware Carbon Black Cloud integration Label used for meta issues tracking each integration Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[carbon_black_cloud] Data loss when using AWS SQS mode
5 participants