Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

box_events: update manifest version format to v3.0.3 #9389

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 20, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:box_events Box Events Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Mar 20, 2024
@efd6 efd6 self-assigned this Mar 20, 2024
@efd6 efd6 force-pushed the 9237-box_events branch 2 times, most recently from eebdd06 to 1ac3cc4 Compare March 20, 2024 00:27
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #9690 failed 1ac3cc47ec26a94e9f48914afca4cdcf1fa316df
  • 💔 Build #9689 failed eebdd065409d8ee528c647cb386e01ed9979b24c

cc @efd6

Copy link

@efd6 efd6 marked this pull request as ready for review March 20, 2024 01:17
@efd6 efd6 requested a review from a team as a code owner March 20, 2024 01:17
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@@ -1181,6 +1181,23 @@ processors:
field: "_ingest._value.indicator.as.organization_name"
target_field: "_ingest._value.indicator.as.organization.name"
ignore_missing: true
# Move geo.ip out of geo and check for IP validity.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this; the IP should never have been put here, but the change here is simpler and easier to understand than fixing the script processors that put the value here.

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit cd0bc83 into elastic:main Mar 22, 2024
5 checks passed
@elasticmachine
Copy link

Package box_events - 2.7.0 containing this change is available at https://epr.elastic.co/search?package=box_events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:box_events Box Events Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants