Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google_Workspace] Moving edge processing to ingest pipeline #939

Merged

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Apr 22, 2021

What does this PR do?

This moves all edge processing to ingest pipelines for the google_workspace package. It also adds some new testdata and pipeline tests.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

@P1llus
Copy link
Member Author

P1llus commented Apr 22, 2021

Work in progress, adding each fileset once they are completed.

@elasticmachine
Copy link

elasticmachine commented Apr 22, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-05-19T22:28:26.239+0000

  • Duration: 15 min 32 sec

  • Commit: 7565b15

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

Trends 🧪

Image of Build Times

Image of Tests

@P1llus P1llus marked this pull request as ready for review May 11, 2021 10:49
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus P1llus requested a review from marc-gr May 11, 2021 10:58
Copy link
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a couple comments that would be nice to have IMO

@P1llus
Copy link
Member Author

P1llus commented May 20, 2021

After some discussion, this will be merged for now, as it only runs once every 2 hours, also any additional things we might want to add can be done later, as this is a blocking change.

@P1llus P1llus merged commit b5b519c into elastic:master May 20, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
…#939)

* stashing changes

* Moving edge processing from admin fileset to pipelines

* adding changelog

* updating google_workspace drive fileset from edge processing to ingest pipeline

* adding all other filesets, updating and fixing some broken processors, ready for review

* renaming all test files to conform to the spec, to pass the elastic-package checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Google Workspace's edge processing to Ingest Node pipeline
3 participants