Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google_scc: update manifest version format to v3.0.3 #9392

Merged
merged 1 commit into from
Mar 27, 2024
Merged

google_scc: update manifest version format to v3.0.3 #9392

merged 1 commit into from
Mar 27, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 20, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:google_scc Google Security Command Center Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Mar 20, 2024
@efd6 efd6 self-assigned this Mar 20, 2024
@efd6 efd6 mentioned this pull request Mar 20, 2024
Closed
31 tasks
@elasticmachine
Copy link

🚀 Benchmarks report

Package google_scc 👍(2) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset 1145.48 670.69 -474.79 (-41.45%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #9890 failed e45982f63cf0e861f1568712d7189e911bb559b1
  • 💔 Build #9698 failed da1aa920d3f621afa7e7c4043569973a34a4761c

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review March 27, 2024 01:25
@efd6 efd6 requested a review from a team as a code owner March 27, 2024 01:25
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 2b20f8e into elastic:main Mar 27, 2024
5 checks passed
@elasticmachine
Copy link

Package google_scc - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=google_scc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:google_scc Google Security Command Center Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @kcreddy