Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k8s package's env references #970

Merged
merged 2 commits into from
May 6, 2021
Merged

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented May 5, 2021

What does this PR do?

This PR fixes default values for k8s package and more specifically references to env variables which should be prefixed with env. so as to be properly evaluated by Agent.

@ChrsMark ChrsMark requested a review from mtojek May 5, 2021 09:05
@ChrsMark ChrsMark self-assigned this May 5, 2021
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@elasticmachine
Copy link

elasticmachine commented May 5, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #970 event

  • Start Time: 2021-05-06T10:07:28.096+0000

  • Duration: 30 min 21 sec

  • Commit: 69c4af7

Test stats 🧪

Test Results
Failed 0
Passed 109
Skipped 0
Total 109

Trends 🧪

Image of Build Times

Image of Tests

@ChrsMark ChrsMark changed the title Fix k8s Fix k8s packages env references May 6, 2021
@ChrsMark ChrsMark changed the title Fix k8s packages env references Fix k8s package's env references May 6, 2021
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrsMark ChrsMark merged commit 6097822 into elastic:master May 6, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants