[Form lib] Error when validating the form with non blocking validations

[sebelga]

Non blocking validation

The form lib allows consumer to declared "non blocking" validations by setting isBlocking: false to a validator.

Let's imagine we have a field with an array of "Tags". In this case, we allow an empty array (no tags needs to be provided) but we want to have a validation when adding a tag to the array (for example: the tag cannot contain the $ character otherwise we won't add it to the array and instead we will show the validation message to the user explaining why the tag could not be added.)

The field, which is the array of tags, is still valid. Simply, no items have been added yet.

The issue

We have an issue in the form lib when validating the form with non blocking validations. Calling form.validate() will call all the validations, including the non blocking ones and thus will block submitting the form.

I've debugged this with @machadoum and the fix might be simple and we might simply need to change the validate() function of the use_field.ts file

const validate: FieldHook<T, I>['validate'] = useCallback(
  (validationData = {}) => {
    const {
      formData = __getFormData$().value,
      value: valueToValidate = value,
      validationType, // before
      validationType = VALIDATION_TYPES.FIELD, // after
    } = validationData;

  ...
}

As this is a very sensitive area of the form lib I want to make sure I haven't overlooked something and obviously add tests around that scenario.

This issue was found by Pablo here: #101756 (comment)

[elasticmachine]

Pinging @elastic/kibana-stack-management (Team:Stack Management)

[cjcenizal]

Seb has this been fixed by #103629?

[sebelga]

Yes @cjcenizal thanks for the ping. Closing as it has been fixed in #103629