Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Monitor detail page no longer functions when fetching pings for bottom table #147659

Closed
justinkambic opened this issue Dec 15, 2022 · 2 comments · Fixed by #147694
Closed

[Synthetics] Monitor detail page no longer functions when fetching pings for bottom table #147659

justinkambic opened this issue Dec 15, 2022 · 2 comments · Fixed by #147694
Assignees
@afgomez
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@justinkambic
Copy link
Contributor

Kibana version:

latest

Elasticsearch version:

latest

Server OS version:

macOS

Browser version:

Chrome 107

Browser OS version:

macOS

Original install method (e.g. download page, yum, from source, etc.):

from source

Describe the bug:

The list of recent checks at the bottom of the monitor detail page does not render unless it enters the viewport to a certain extent. When it does, it dispatches getMonitorLastRunAction.get. For some reason, this action causes components further up the page's component tree to re-render, or re-fetch data based on loading flags and some other state.

Steps to reproduce:

  1. Ingest monitor detail data
  2. Navigate to the detail page in synthetics
  3. Scroll down
  4. Observe the problem

Expected behavior:

The pings should load data and display it, and should only subsequently re-fetch when the query's dependencies change.

Screenshots (if relevant):

20221215120845
@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Dec 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@afgomez afgomez self-assigned this Dec 16, 2022
@paulb-elastic
Copy link
Contributor

This seems to be happening on main but not the 8.6 branch

@afgomez afgomez mentioned this issue Dec 16, 2022
Merged
afgomez pushed a commit that referenced this issue Dec 19, 2022
@kibanamachine
[Synthetics UI] Remove 404 check (#147694)
e03f8f0 
Fixes #147659

We were using a hook in a non-React context and that was messing up with
how React kept state internally. That caused some other hooks to not
save their own state and trigger infinite re-renders down the line in
some scenarios.

We will need to revisit how we check for 404 errors.

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afgomez afgomez

Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Synthetics UI] Remove 404 check afgomez/kibana
4 participants
@afgomez @elasticmachine @justinkambic @paulb-elastic