Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map layer preview blocks adding layer until all tiles are loaded. #159872

Closed
desean1625 opened this issue Jun 16, 2023 · 3 comments · Fixed by #161994
Closed

Map layer preview blocks adding layer until all tiles are loaded. #159872

desean1625 opened this issue Jun 16, 2023 · 3 comments · Fixed by #161994
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@desean1625
Copy link
Contributor

Steps to reproduce:

  1. start to add layer
  2. try and click add layer before the data request starts
  3. cant add layer because the button is disabled until all data requests are complete

Expected behavior:
Button not to disable

We have a remote cluster that is really slow to respond this makes it so we have to wait for it to timeout or finish before we can add the layer. Sometimes the remote cluster can take 20+ seconds
@desean1625 desean1625 added the bug Fixes for quality problems that affect the customer experience label Jun 16, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 19, 2023
@jsanz jsanz added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Geo labels Jun 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@jsanz
Copy link
Member

jsanz commented Jun 19, 2023

I've experienced this issue when loading layers that are hitting a lot of results (or aggregating a lot of data by default) and I agree it would be nice to have the button enabled right away.

@nreese nreese self-assigned this Jul 14, 2023
@nreese nreese mentioned this issue Jul 14, 2023
Merged
nreese added a commit that referenced this issue Jul 18, 2023
@nreese @kibanamachine
[maps] fix Map layer preview blocks adding layer until all tiles are …
9a87af0 
…loaded (#161994)

Closes #159872

<img width="500" alt="Screen Shot 2023-07-14 at 1 56 45 PM"
src="https://github.com/elastic/kibana/assets/373691/b4fc762e-dc5e-48dc-a37f-b0936f02b00b">


Do not disable add layer buttons while preview layer is loading

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@nreese @kibanamachine
[maps] fix Map layer preview blocks adding layer until all tiles are …
d9b4e1b 
…loaded (elastic#161994)

Closes elastic#159872

<img width="500" alt="Screen Shot 2023-07-14 at 1 56 45 PM"
src="https://github.com/elastic/kibana/assets/373691/b4fc762e-dc5e-48dc-a37f-b0936f02b00b">


Do not disable add layer buttons while preview layer is loading

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@desean1625 desean1625 mentioned this issue Sep 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[maps] fix Map layer preview blocks adding layer until all tiles are loaded nreese/kibana
5 participants
@jsanz @nreese @mbondyra @desean1625 @elasticmachine