Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notifications] Saving dataview notification is overflowing the notification banner #163330

Closed
bhavyarm opened this issue Aug 7, 2023 · 1 comment · Fixed by #166350
Closed

[Notifications] Saving dataview notification is overflowing the notification banner #163330

bhavyarm opened this issue Aug 7, 2023 · 1 comment · Fixed by #166350
Assignees
@vadimkibana
Labels
bug Fixes for quality problems that affect the customer experience Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Aug 7, 2023

Kibana version: main

Browser version: chrome latest

Serverless project: Observability

Original install method (e.g. download page, yum, from source, etc.): from QA

Describe the bug: When you save a dataview - the dataview saved notification text is overflowing the notification banner

Screenshot 2023-08-07 at 11 02 31 AM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release labels Aug 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@vadimkibana vadimkibana changed the title Saving dataview notification is overflowing the notification banner [Notifications] Saving dataview notification is overflowing the notification banner Aug 11, 2023
@vadimkibana vadimkibana mentioned this issue Sep 13, 2023
Closed
@vadimkibana vadimkibana self-assigned this Sep 13, 2023
@vadimkibana vadimkibana mentioned this issue Sep 13, 2023
Merged
vadimkibana added a commit that referenced this issue Sep 13, 2023
@vadimkibana
do not overflow notification card with data view name (#166350)
b425081 
## Summary

Closes #163330

Data view names are not rendered as body, instead of title, hence long
titles overflow, like so:

<img width="366" alt="Screenshot 2023-09-13 at 15 06 16"
src="https://github.com/elastic/kibana/assets/82822460/388479c4-9908-4887-94eb-e59298bd2cc1">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadimkibana vadimkibana

Labels
bug Fixes for quality problems that affect the customer experience Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Data Views] Do not overflow notification card with long data view name vadimkibana/kibana
3 participants
@bhavyarm @elasticmachine @vadimkibana