Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow excluding of fields from highlighting in Discover #16877

Closed
trevan opened this issue Feb 22, 2018 · 7 comments
Closed

Allow excluding of fields from highlighting in Discover #16877

trevan opened this issue Feb 22, 2018 · 7 comments
Labels
enhancement New value added to drive a business result Feature:Highlight Highlighting of content via query Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@trevan
Copy link
Contributor

trevan commented Feb 22, 2018

Elasticsearch will start throwing exceptions for large fields that you try and highlight on unless you have certain settings turned on (see #16764 for more details).

It would be nice to disable highlighting on those large fields for users that don't want to modify the cluster/index settings.

@Bargs
Copy link
Contributor

Bargs commented Feb 23, 2018

Thanks for filing this @trevan. This would also be a nice query optimization for users with large fields who simply don't need highlighting on everything.

The biggest question for me is how this setting should be implemented. Should it be an index pattern level setting? What if users want to control highlighting per saved search? If we implement it at the saved search level though, it takes away an admin's ability to globally disable expensive highlighting on expensive fields (or fields large enough to trigger errors in ES). Perhaps we should have both eventually, but index patterns would be a good place to start?

@trevan
Copy link
Contributor Author

trevan commented Feb 23, 2018

I would vote for putting it at the index pattern (or maybe even in the index mapping in elasticsearch if that is possible).

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure :Discovery labels Sep 16, 2018
@balthazar
Copy link
Contributor

balthazar commented Jun 8, 2020

Sorry to dig this up but was there any progress on disabling highlighting for some fields? Mine isn't even indexed so I would love to disable highlighting for it, as it can grow bigger than 10M in some cases.

@plumpNation
Copy link

Would love to see this feature. For those who cannot reindex easily, but do not want to take the recommended-against path of increasing index.highlight.max_analyzed_offset

@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@timroes timroes added Feature:Highlight Highlighting of content via query Feature:Search Querying infrastructure in Kibana Team:AppServices and removed Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@timroes
Copy link
Contributor

timroes commented Sep 15, 2021

I am moving this over to App Services, since I believe we most likely want to exclude those fields from highlighting in index patterns, and the code for exclusion would ideally be completely inside SearchSource.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 27, 2021
@ppisljar
Copy link
Member

ppisljar commented Aug 9, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Highlight Highlighting of content via query Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

7 participants