Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDR Workflows] The inconsistent use of unisolate and release endpoint should be removed #168779

Closed
muskangulati-qasource opened this issue Oct 13, 2023 · 9 comments · Fixed by #173831
Closed

[EDR Workflows] The inconsistent use of unisolate and release endpoint should be removed #168779

muskangulati-qasource opened this issue Oct 13, 2023 · 9 comments · Fixed by #173831
Assignees
@ashokaditya @kevinlog
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. OLM Sprint QA:Validated Issue has been validated by QA regression Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.4 v8.11.0

Comments

@muskangulati-qasource
Copy link

Description:
The inconsistent use of unisolate and release endpoint should be removed

Build Details:

VERSION: 8.10.4
BUILD: 66491
COMMIT: 976088dd04c6fd3b907fd2bb92af306e7d77ce4c

Browser Details:
All

Preconditions:

  1. Kibana user should be logged in

Steps to Reproduce:

  1. Login to a fresh Kibana environment
  2. Navigate to the 'Endpoints' tab under the Manage section of Security
  3. Isolate a host and then release the host
  4. Observe the status under the response action history

Actual Result:
The inconsistent use of unisolate and release endpoint is shown

Expected Result:
The inconsistent use of unisolate and release endpoint should be removed

Screenshots:
Unisolate1
Unisolate2

Logs
N/A
@muskangulati-qasource muskangulati-qasource added bug Fixes for quality problems that affect the customer experience regression impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.0 v8.10.4 labels Oct 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@muskangulati-qasource
Copy link
Author

@manishgupta-qasource please review!

@manishgupta-qasource
Copy link

Reviewed & assigned to @kevinlog

@muskangulati-qasource
Copy link
Author

Hi @kevinlog,

This issue is still occurring on 8.12.0 for release.

image

We have updated the labels to 8.12.0.

Thanks!

@ashokaditya ashokaditya self-assigned this Dec 21, 2023
ashokaditya added a commit to ashokaditya/kibana that referenced this issue Dec 21, 2023
@ashokaditya
map unisolate to release command on history output
3402be2 
closes elastic/issues/168779
ashokaditya added a commit to ashokaditya/kibana that referenced this issue Dec 21, 2023
@ashokaditya
map unisolate to release command on history output
ecbe88e 
closes elastic/issues/168779
@ashokaditya ashokaditya mentioned this issue Dec 21, 2023
Merged
4 tasks
ashokaditya added a commit to ashokaditya/kibana that referenced this issue Dec 21, 2023
@ashokaditya
map unisolate to release command on history output
1ec7e75 
closes elastic/issues/168779
ashokaditya added a commit to ashokaditya/kibana that referenced this issue Dec 21, 2023
@ashokaditya
map unisolate to release command on history output
7fb7753 
closes elastic/issues/168779
ashokaditya added a commit that referenced this issue Dec 21, 2023
@ashokaditya
[Security Solution][Endpoint] Map unisolate to release and `runni…
3781a0d 
…ng-processes` to `processes` commands on response actions history output tray (#173831)

## Summary

Shows `release` instead of `unisolate` and `processes` instead of
`running-processes` on the response actions history output tray.

**with this change**
![Screenshot 2023-12-21 at 2 40
03 PM](https://github.com/elastic/kibana/assets/1849116/3fb0ffe5-4f8b-4caa-9238-380d39f199bf)

![Screenshot 2023-12-21 at 3 43
57 PM](https://github.com/elastic/kibana/assets/1849116/1d3e67f4-d2f9-49a3-8a7b-01979e7ecbcd)

closes /issues/168779

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
@ashokaditya ashokaditya added the QA:Ready for Testing Code is merged and ready for QA to validate label Dec 21, 2023
@ashokaditya
Copy link
Member

@muskangulati-qasource the fix should be ready to test in the next 8.12 build.

@ashokaditya
Copy link
Member

PR /pull/173831

kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 21, 2023
@ashokaditya
[Security Solution][Endpoint] Map unisolate to release and `runni…
a800a66 
…ng-processes` to `processes` commands on response actions history output tray (elastic#173831)

## Summary

Shows `release` instead of `unisolate` and `processes` instead of
`running-processes` on the response actions history output tray.

**with this change**
![Screenshot 2023-12-21 at 2 40
03 PM](https://github.com/elastic/kibana/assets/1849116/3fb0ffe5-4f8b-4caa-9238-380d39f199bf)

![Screenshot 2023-12-21 at 3 43
57 PM](https://github.com/elastic/kibana/assets/1849116/1d3e67f4-d2f9-49a3-8a7b-01979e7ecbcd)

closes elastic/issues/168779

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

(cherry picked from commit 3781a0d)
kibanamachine added a commit that referenced this issue Dec 21, 2023
@kibanamachine @ashokaditya
[8.12] [Security Solution][Endpoint] Map unisolate to release and…
a599b31 
… `running-processes` to `processes` commands on response actions history output tray (#173831) (#173852)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Security Solution][Endpoint] Map `unisolate` to `release` and
`running-processes` to `processes` commands on response actions history
output tray (#173831)](#173831)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-12-21T15:56:31Z","message":"[Security
Solution][Endpoint] Map `unisolate` to `release` and `running-processes`
to `processes` commands on response actions history output tray
(#173831)\n\n## Summary\r\n\r\nShows `release` instead of `unisolate`
and `processes` instead of\r\n`running-processes` on the response
actions history output tray.\r\n\r\n**with this change**\r\n![Screenshot
2023-12-21 at 2
40\r\n03 PM](https://github.com/elastic/kibana/assets/1849116/3fb0ffe5-4f8b-4caa-9238-380d39f199bf)\r\n\r\n![Screenshot
2023-12-21 at 3
43\r\n57 PM](https://github.com/elastic/kibana/assets/1849116/1d3e67f4-d2f9-49a3-8a7b-01979e7ecbcd)\r\n\r\ncloses
/issues/168779\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"3781a0dcd185550e2beaa2701c1ec95ad4f19915","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Defend
Workflows","OLM
Sprint","v8.12.0","v8.13.0"],"number":173831,"url":"https://github.com/elastic/kibana/pull/173831","mergeCommit":{"message":"[Security
Solution][Endpoint] Map `unisolate` to `release` and `running-processes`
to `processes` commands on response actions history output tray
(#173831)\n\n## Summary\r\n\r\nShows `release` instead of `unisolate`
and `processes` instead of\r\n`running-processes` on the response
actions history output tray.\r\n\r\n**with this change**\r\n![Screenshot
2023-12-21 at 2
40\r\n03 PM](https://github.com/elastic/kibana/assets/1849116/3fb0ffe5-4f8b-4caa-9238-380d39f199bf)\r\n\r\n![Screenshot
2023-12-21 at 3
43\r\n57 PM](https://github.com/elastic/kibana/assets/1849116/1d3e67f4-d2f9-49a3-8a7b-01979e7ecbcd)\r\n\r\ncloses
/issues/168779\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"3781a0dcd185550e2beaa2701c1ec95ad4f19915"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173831","number":173831,"mergeCommit":{"message":"[Security
Solution][Endpoint] Map `unisolate` to `release` and `running-processes`
to `processes` commands on response actions history output tray
(#173831)\n\n## Summary\r\n\r\nShows `release` instead of `unisolate`
and `processes` instead of\r\n`running-processes` on the response
actions history output tray.\r\n\r\n**with this change**\r\n![Screenshot
2023-12-21 at 2
40\r\n03 PM](https://github.com/elastic/kibana/assets/1849116/3fb0ffe5-4f8b-4caa-9238-380d39f199bf)\r\n\r\n![Screenshot
2023-12-21 at 3
43\r\n57 PM](https://github.com/elastic/kibana/assets/1849116/1d3e67f4-d2f9-49a3-8a7b-01979e7ecbcd)\r\n\r\ncloses
/issues/168779\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"3781a0dcd185550e2beaa2701c1ec95ad4f19915"}}]}]
BACKPORT-->

Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
@muskangulati-qasource
Copy link
Author

Bug Conversion

Thanks!

@muskangulati-qasource
Copy link
Author

Hi @dasansol92,

We have validated the issue on the latest 8.13.0-SNAPSHOT build. Please find below the testing details:

Build Details

VERSION: 8.13.0
BUILD: 71308
COMMIT: 3ef1e76667a9473c1bf31b2cc7176c4f8311ea54

Observation & Screenshot

  • The release command is consistently used in all tabs now 🟢
    image

Hence, we are marking this issue as 'QA Validated'.

Thanks!

@muskangulati-qasource muskangulati-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashokaditya ashokaditya

@kevinlog kevinlog

Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. OLM Sprint QA:Validated Issue has been validated by QA regression Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.4 v8.11.0
Projects
None yet
Milestone
No milestone
5 participants
@ashokaditya @elasticmachine @kevinlog @manishgupta-qasource @muskangulati-qasource