Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Provide initial size for the SLO Overview embeddable #170710

Closed
mgiota opened this issue Nov 7, 2023 · 2 comments · Fixed by #170720
Closed

[SLO] Provide initial size for the SLO Overview embeddable #170710

mgiota opened this issue Nov 7, 2023 · 2 comments · Fixed by #170720
Assignees
Labels
Feature:SLO Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:obs-ux-management Observability Management User Experience Team v8.12.0

Comments

@mgiota
Copy link
Contributor

mgiota commented Nov 7, 2023

Slack thread

🍒 Summary

In this issue we implemented an SLO Overview embeddable. The panel takes the default width and height dimensions based on the dashboards grid system.

DEFAULT_PANEL_WIDTH = 24
DEFAULT_PANEL_HEIGHT = 15

With this PR we now have the option to specify initial width and height of our panel by providing a getPanelPlacementSettings in the embeddable's factory.

✅ Acceptance criteria

  • specify the initial width and height of the SLO overview embeddable. I tried width: 8 and height: 7 and looks good, so I'll start with these values

Implementation details

We need to specify a getPanelPlacementSettings to the SLO Overview embeddable

 public getPanelPlacementSettings: IProvidesPanelPlacementSettings<
    SloEmbeddableInput,
    unknown
  >['getPanelPlacementSettings'] = () => {
    return { width: 8, height: 7, strategy: 'placeAtTop' };
  };

The SloOverviewEmbeddableFactoryDefinition needs to implement the IProvidesPanelPlacementSettings<SloEmbeddableInput> as well.

class SloOverviewEmbeddableFactoryDefinition implements EmbeddableFactoryDefinition, IProvidesPanelPlacementSettings<SloEmbeddableInput>

🗒️ Notes for the Reviewer

Already placed panels (Admin console availability SLO), still take the default dimensions. This change applies only to the newly added SLO Overview panels.

Verify that width: 8, height: 7 works well with your existing SLO widgets. In any case user can resize the panel and bring it to the desired dimensions!

Screenshot 2023-11-07 at 08 39 43
@mgiota mgiota self-assigned this Nov 7, 2023
@mgiota mgiota added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Nov 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

mgiota added a commit that referenced this issue Nov 9, 2023
…able (#170720)

Fixes #170710

<img width="1007" alt="Screenshot 2023-11-07 at 11 52 38"
src="https://github.com/elastic/kibana/assets/2852703/b39e999e-8823-4e02-bcb4-8e08e76b799d">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@mgiota mgiota added the Team:obs-ux-management Observability Management User Experience Team label Nov 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:SLO Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:obs-ux-management Observability Management User Experience Team v8.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants