Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Disabling alerting for a monitor filters out TLS data in certs view #178334

Closed
justinkambic opened this issue Mar 8, 2024 · 1 comment · Fixed by #178336
Closed

[Synthetics] Disabling alerting for a monitor filters out TLS data in certs view #178334

justinkambic opened this issue Mar 8, 2024 · 1 comment · Fixed by #178336
Assignees
@justinkambic
Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@justinkambic
Copy link
Contributor

justinkambic commented Mar 8, 2024 •
edited
Loading

Kibana version:

8.12.2 and below

Elasticsearch version:

8.12.2 and below

Server OS version:

macOS

Browser version:

Chrome

Browser OS version:

macOS

Original install method (e.g. download page, yum, from source, etc.):

ESS/from source/all

Describe the bug:

When users create monitors, they can choose to disable alerts for the monitor status or the TLS certificate age. If they disable monitor status alerts for the monitor in question, any TLS data it collects will not display on the certificates page.

Steps to reproduce:

  1. Start creating an HTTP monitor in Synthetics
  2. Disable the monitor status alerts
  3. Create the monitor and allow it to collect data
  4. (Optional): verify TLS data is present, if you monitor a public website like elastic.co or google.com this verification isn't necessary
  5. Navigate to the TLS page in Synthetics, your data should not appear

Expected behavior:

TLS data should appear for any monitor that is enabled.

Screenshots (if relevant):

image

Errors in browser console (if relevant):

N/A

Provide logs and/or server output (if relevant):

N/A

Any additional context:

The user can work around this problem by enabling Uptime, setting the index pattern in Uptime settings to synthetics* and using the TLS view in that plugin instead until this issue is fixed.

This was first discovered as part of an SDH.
@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Mar 8, 2024
@justinkambic justinkambic self-assigned this Mar 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@justinkambic justinkambic mentioned this issue Mar 8, 2024
Merged
justinkambic added a commit that referenced this issue Mar 11, 2024
@justinkambic
[Synthetics] Fix Certificates page for monitors that have status aler…
02009d7 
…t disabled (#178336)

## Summary

Resolves #178334.

We discovered that we were accidentally looking at the wrong field when
filtering monitors for the TLS page in Synthetics.

This patch switches to the right field.

### After

<img width="2160" alt="image"
src="https://github.com/elastic/kibana/assets/18429259/a2ab42cf-dc6c-42ba-892c-6a95187a7351">

### Before

<img width="2163" alt="image"
src="https://github.com/elastic/kibana/assets/18429259/964a0da3-fba8-4ce7-86cd-6d6c0df0dd59">


## Testing

There are detailed repro instructions on the linked issue. On `main`,
you can follow those instructions (create an http monitor with status
alerts disabled, navigate to TLS page, see no data). Then `checkout`
this PR and refresh the page, you should see your TLS data.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Mar 11, 2024
@justinkambic
[Synthetics] Fix Certificates page for monitors that have status aler…
67734e8 
…t disabled (elastic#178336)

## Summary

Resolves elastic#178334.

We discovered that we were accidentally looking at the wrong field when
filtering monitors for the TLS page in Synthetics.

This patch switches to the right field.

### After

<img width="2160" alt="image"
src="https://github.com/elastic/kibana/assets/18429259/a2ab42cf-dc6c-42ba-892c-6a95187a7351">

### Before

<img width="2163" alt="image"
src="https://github.com/elastic/kibana/assets/18429259/964a0da3-fba8-4ce7-86cd-6d6c0df0dd59">

## Testing

There are detailed repro instructions on the linked issue. On `main`,
you can follow those instructions (create an http monitor with status
alerts disabled, navigate to TLS page, see no data). Then `checkout`
this PR and refresh the page, you should see your TLS data.

(cherry picked from commit 02009d7)
kibanamachine added a commit that referenced this issue Mar 11, 2024
@kibanamachine @justinkambic
[8.13] [Synthetics] Fix Certificates page for monitors that have stat…
501714d 
…us alert disabled (#178336) (#178418)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Synthetics] Fix Certificates page for monitors that have status
alert disabled (#178336)](#178336)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Justin
Kambic","email":"jk@elastic.co"},"sourceCommit":{"committedDate":"2024-03-11T17:35:44Z","message":"[Synthetics]
Fix Certificates page for monitors that have status alert disabled
(#178336)\n\n## Summary\r\n\r\nResolves #178334.\r\n\r\nWe discovered
that we were accidentally looking at the wrong field when\r\nfiltering
monitors for the TLS page in Synthetics.\r\n\r\nThis patch switches to
the right field.\r\n\r\n### After\r\n\r\n<img width=\"2160\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/18429259/a2ab42cf-dc6c-42ba-892c-6a95187a7351\">\r\n\r\n###
Before\r\n\r\n<img width=\"2163\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/18429259/964a0da3-fba8-4ce7-86cd-6d6c0df0dd59\">\r\n\r\n\r\n##
Testing\r\n\r\nThere are detailed repro instructions on the linked
issue. On `main`,\r\nyou can follow those instructions (create an http
monitor with status\r\nalerts disabled, navigate to TLS page, see no
data). Then `checkout`\r\nthis PR and refresh the page, you should see
your TLS
data.","sha":"02009d7f4887b53c103a308b5a81c59f12845433","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:obs-ux-infra_services","v8.13.0","v8.14.0"],"title":"[Synthetics]
Fix Certificates page for monitors that have status alert
disabled","number":178336,"url":"https://github.com/elastic/kibana/pull/178336","mergeCommit":{"message":"[Synthetics]
Fix Certificates page for monitors that have status alert disabled
(#178336)\n\n## Summary\r\n\r\nResolves #178334.\r\n\r\nWe discovered
that we were accidentally looking at the wrong field when\r\nfiltering
monitors for the TLS page in Synthetics.\r\n\r\nThis patch switches to
the right field.\r\n\r\n### After\r\n\r\n<img width=\"2160\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/18429259/a2ab42cf-dc6c-42ba-892c-6a95187a7351\">\r\n\r\n###
Before\r\n\r\n<img width=\"2163\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/18429259/964a0da3-fba8-4ce7-86cd-6d6c0df0dd59\">\r\n\r\n\r\n##
Testing\r\n\r\nThere are detailed repro instructions on the linked
issue. On `main`,\r\nyou can follow those instructions (create an http
monitor with status\r\nalerts disabled, navigate to TLS page, see no
data). Then `checkout`\r\nthis PR and refresh the page, you should see
your TLS
data.","sha":"02009d7f4887b53c103a308b5a81c59f12845433"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178336","number":178336,"mergeCommit":{"message":"[Synthetics]
Fix Certificates page for monitors that have status alert disabled
(#178336)\n\n## Summary\r\n\r\nResolves #178334.\r\n\r\nWe discovered
that we were accidentally looking at the wrong field when\r\nfiltering
monitors for the TLS page in Synthetics.\r\n\r\nThis patch switches to
the right field.\r\n\r\n### After\r\n\r\n<img width=\"2160\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/18429259/a2ab42cf-dc6c-42ba-892c-6a95187a7351\">\r\n\r\n###
Before\r\n\r\n<img width=\"2163\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/18429259/964a0da3-fba8-4ce7-86cd-6d6c0df0dd59\">\r\n\r\n\r\n##
Testing\r\n\r\nThere are detailed repro instructions on the linked
issue. On `main`,\r\nyou can follow those instructions (create an http
monitor with status\r\nalerts disabled, navigate to TLS page, see no
data). Then `checkout`\r\nthis PR and refresh the page, you should see
your TLS data.","sha":"02009d7f4887b53c103a308b5a81c59f12845433"}}]}]
BACKPORT-->

Co-authored-by: Justin Kambic <jk@elastic.co>
@axrayn axrayn mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinkambic justinkambic

Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Synthetics] Fix Certificates page for monitors that have status alert disabled justinkambic/kibana
2 participants
@elasticmachine @justinkambic