Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved Object editor is dependent of the index pattern existing #3914

Closed
spalger opened this issue May 21, 2015 · 0 comments · Fixed by #3917
Closed

Saved Object editor is dependent of the index pattern existing #3914

spalger opened this issue May 21, 2015 · 0 comments · Fixed by #3917
Assignees
@spalger
Labels
blocker bug Fixes for quality problems that affect the customer experience v4.1.0

Comments

@spalger
Copy link
Contributor

spalger commented May 21, 2015

The Saved Object editor is supposed to be the last resort for fixing broken objects, but currently if you delete an index pattern and try to view the saved object the editor fails to load with a fatal error.

image
@spalger spalger added bug Fixes for quality problems that affect the customer experience blocker v4.1.0 labels May 21, 2015
@spalger spalger self-assigned this May 21, 2015
spalger pushed a commit to spalger/kibana that referenced this issue May 21, 2015
[settings/objectEditor] read mapping rather than using service#get
653a59e 
We were previously using service#get() to load a saved object before loading it into the saved object editor. This allowed
us to edit fields that were not actually saved to the object but needed an editor. Now, we are reading the mapping config
off of the SavedObject class so that we don't have to actually load the savedObject.

This fixes elastic#3914 which was caused by the savedObject class rejecting the #get()
promise due to a missing indexPattern.
@spalger spalger mentioned this issue May 21, 2015
Merged
spalger pushed a commit to spalger/kibana that referenced this issue May 21, 2015
[settings/objectEditor] read mapping rather than using service#get
11cde58 
We were previously using service#get() to load a saved object before loading it into the saved object editor. This allowed
us to edit fields that were not actually saved to the object but needed an editor. Now, we are reading the mapping config
off of the SavedObject class so that we don't have to actually load the savedObject.

This fixes elastic#3914 which was caused by the savedObject class rejecting the #get()
promise due to a missing indexPattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spalger spalger

Labels
blocker bug Fixes for quality problems that affect the customer experience v4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[settings/objectEditor] read mapping rather than using service#get spalger/kibana
1 participant
@spalger