Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove icon property from feature registration #43184

Closed
legrego opened this issue Aug 13, 2019 · 3 comments · Fixed by #80909
Closed

Remove icon property from feature registration #43184

legrego opened this issue Aug 13, 2019 · 3 comments · Fixed by #80909
Assignees
@legrego
Labels
enhancement New value added to drive a business result Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@legrego
Copy link
Member

legrego commented Aug 13, 2019 •
edited
Loading

Updated issue:
The updated design language for Spaces and Role Management will actually remove the feature icons in favor of a categorized display (via #54793 and #54794).

Original issue:

When registering features, plugins can currently only use the predefined icon list from EUI. While this works great for first-party plugins, this is rather limiting for third-party plugins, as their icons simply won't be available in EUI.

Kibana's feature registration should allow for custom icons to be used in the event that a suitable one is not available within EUI.
@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls labels Aug 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@legrego
Copy link
Member Author

legrego commented Aug 13, 2019

/cc @jesusgn90

@jesusgn90 jesusgn90 mentioned this issue Aug 13, 2019
Closed
@legrego
Copy link
Member Author

legrego commented Sep 22, 2020

The updated design language for Spaces and Role Management will actually remove the feature icons in favor of a categorized display (via #54793 and #54794).

Once that work is completed, my plan is to remove the icon property from feature registration altogether. I will rename this issue to reflect that change instead

@legrego legrego changed the title Feature Controls - Allow custom feature icons Remove icon property from feature registration Sep 22, 2020
@legrego legrego self-assigned this Oct 2, 2020
@legrego legrego mentioned this issue Oct 16, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legrego legrego

Labels
enhancement New value added to drive a business result Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup feature registration legrego/kibana
2 participants
@legrego @elasticmachine