Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup feature registration #80909

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Cleanup feature registration #80909

merged 1 commit into from
Oct 20, 2020

Conversation

legrego
Copy link
Member

@legrego legrego commented Oct 16, 2020 •
edited
Loading

Plugin API changes

  1. Removes the icon and navLinkId options from Feature registration.
    • icon was used on the Spaces and Role Management interfaces, but a recent redesign of these screens has rendered the icon unnecessary.
    • navLinkId was only required by the legacy platform, and is therefore no longer supported in versions >= 7.11.0
  2. Renames the validLicenses property to minimumLicense
    • The existing property was unnecessarily configurable. This rename aligns the property with the licensing plugin's functionality, which has built-in support for checking a minimum license against the current license.

Resolves #66217
Resolves #43184

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
features 15.8KB 15.7KB -122.0B

History

  • 💔 Build #82295 failed 1551e61b98818f97a53d00cf5db977ff5be127be
  • 💔 Build #82288 failed c921dfb22324ba24bf96f4db45fa7f7c41f94359

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.11.0 v8.0.0 labels Oct 19, 2020
@legrego legrego marked this pull request as ready for review October 19, 2020 13:20
@legrego legrego requested review from a team as code owners October 19, 2020 13:20
@legrego legrego requested review from a team October 19, 2020 13:20
@legrego legrego requested a review from a team as a code owner October 19, 2020 13:20
@legrego legrego requested a review from a team October 19, 2020 13:20
@legrego legrego requested review from a team as code owners October 19, 2020 13:20
@legrego legrego requested a review from a team October 19, 2020 13:20
@legrego legrego requested a review from a team as a code owner October 19, 2020 13:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

scottybollinger
scottybollinger approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Enterprise Search

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@jportner
Copy link
Contributor

ACK: reviewing now

jportner
jportner approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security and Spaces changes LGTM!

weltenwort
weltenwort approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra plugin changes LGTM

chrisronline
chrisronline approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for stack monitoring!

nreese
nreese approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maps changes LGTM
code review

peteharverson
peteharverson approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML code changes LGTM

sorenlouv
sorenlouv approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes lgtm

justinkambic
justinkambic approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM!

flash1293
flash1293 approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana App changes lgtm, as long as 'enterprise', 'trial' is a higher license than 'platinum'.

@legrego
Copy link
Member Author

legrego commented Oct 20, 2020

Kibana App changes lgtm, as long as 'enterprise', 'trial' is a higher license than 'platinum'.

Yep! platinum is the lowest of those license levels

mikecote
mikecote approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting team related code LGTM

patrykkopycinski
patrykkopycinski approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIEM/Endpoint LGTM

poffdeluxe
poffdeluxe approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

canvas changes LGTM

@legrego legrego merged commit bf0f8bb into elastic:master Oct 20, 2020
@legrego legrego deleted the fc/cleanup-interface branch October 20, 2020 16:53
@legrego legrego mentioned this pull request Oct 20, 2020
Merged
legrego added a commit that referenced this pull request Oct 20, 2020
@legrego
[7.x] Cleanup feature registration (#80909) (#81209)
5ec80bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@mikecote mikecote mikecote approved these changes

@mshustov mshustov mshustov approved these changes

@jen-huang jen-huang jen-huang approved these changes

@justinkambic justinkambic justinkambic approved these changes

@flash1293 flash1293 flash1293 approved these changes

@weltenwort weltenwort weltenwort approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@nreese nreese nreese approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@peteharverson peteharverson peteharverson approved these changes

@chrisronline chrisronline chrisronline approved these changes

@scottybollinger scottybollinger scottybollinger approved these changes

Assignees
No one assigned
Labels
release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove navLinkId property from feature registration Remove icon property from feature registration