Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Map tooltips should show corresponding source/destination ip instead of host.ip #44493

Closed
spong opened this issue Aug 30, 2019 · 2 comments
Closed

[SIEM] Map tooltips should show corresponding source/destination ip instead of host.ip #44493

spong opened this issue Aug 30, 2019 · 2 comments
Assignees
@spong
Labels
bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.4.0 v8.0.0

Comments

@spong
Copy link
Member

spong commented Aug 30, 2019

When clicking a source or destination point on the map, the tooltip should show source.ip or destination.ip instead of host.ip.

image
@spong spong added bug Fixes for quality problems that affect the customer experience v8.0.0 v7.4.0 labels Aug 30, 2019
@spong spong self-assigned this Aug 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem

@spong
Copy link
Member Author

spong commented Sep 3, 2019

As discussed, also adding domain and asn for both source/destination.

@spong spong mentioned this issue Sep 3, 2019
Merged
7 tasks
spong added a commit that referenced this issue Sep 4, 2019
@spong
[SIEM] Updates fields in map tooltip and fixes filtering on undefined…
7994a2c 
… values (#44718)

## Summary

Updates the fields within the source/destination feature tooltips to show the following (#44493):
  * `host.name` 
  * `source/destination.ip` 
  * `source/destination.domain` 
  * `source/destination.as.organization.name` 

![image](https://user-images.githubusercontent.com/2946766/64210040-6bf5da00-ce5f-11e9-9331-0ab98aaefd35.png)

Fixes filtering on undefined field values (#44711)

![maps_filtering_fix](https://user-images.githubusercontent.com/2946766/64210200-dc9cf680-ce5f-11e9-8e51-5b87588569be.gif)


Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
spong added a commit to spong/kibana that referenced this issue Sep 4, 2019
@spong
[SIEM] Updates fields in map tooltip and fixes filtering on undefined…
e48ccb0 
… values (elastic#44718)

## Summary

Updates the fields within the source/destination feature tooltips to show the following (elastic#44493):
  * `host.name` 
  * `source/destination.ip` 
  * `source/destination.domain` 
  * `source/destination.as.organization.name` 

![image](https://user-images.githubusercontent.com/2946766/64210040-6bf5da00-ce5f-11e9-9331-0ab98aaefd35.png)

Fixes filtering on undefined field values (elastic#44711)

![maps_filtering_fix](https://user-images.githubusercontent.com/2946766/64210200-dc9cf680-ce5f-11e9-8e51-5b87588569be.gif)


Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
spong added a commit to spong/kibana that referenced this issue Sep 4, 2019
@spong
[SIEM] Updates fields in map tooltip and fixes filtering on undefined…
73b31af 
… values (elastic#44718)

## Summary

Updates the fields within the source/destination feature tooltips to show the following (elastic#44493):
  * `host.name` 
  * `source/destination.ip` 
  * `source/destination.domain` 
  * `source/destination.as.organization.name` 

![image](https://user-images.githubusercontent.com/2946766/64210040-6bf5da00-ce5f-11e9-9331-0ab98aaefd35.png)

Fixes filtering on undefined field values (elastic#44711)

![maps_filtering_fix](https://user-images.githubusercontent.com/2946766/64210200-dc9cf680-ce5f-11e9-8e51-5b87588569be.gif)


Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
@spong spong closed this as completed Sep 4, 2019
spong added a commit that referenced this issue Sep 4, 2019
@spong
[SIEM] Updates fields in map tooltip and fixes filtering on undefined…
7b91c5e 
… values (#44718) (#44744)

## Summary

Updates the fields within the source/destination feature tooltips to show the following (#44493):
  * `host.name` 
  * `source/destination.ip` 
  * `source/destination.domain` 
  * `source/destination.as.organization.name` 

![image](https://user-images.githubusercontent.com/2946766/64210040-6bf5da00-ce5f-11e9-9331-0ab98aaefd35.png)

Fixes filtering on undefined field values (#44711)

![maps_filtering_fix](https://user-images.githubusercontent.com/2946766/64210200-dc9cf680-ce5f-11e9-8e51-5b87588569be.gif)


Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
spong added a commit that referenced this issue Sep 4, 2019
@spong
[SIEM] Updates fields in map tooltip and fixes filtering on undefined…
2ecbaa5 
… values (#44718) (#44745)

## Summary

Updates the fields within the source/destination feature tooltips to show the following (#44493):
  * `host.name` 
  * `source/destination.ip` 
  * `source/destination.domain` 
  * `source/destination.as.organization.name` 

![image](https://user-images.githubusercontent.com/2946766/64210040-6bf5da00-ce5f-11e9-9331-0ab98aaefd35.png)

Fixes filtering on undefined field values (#44711)

![maps_filtering_fix](https://user-images.githubusercontent.com/2946766/64210200-dc9cf680-ce5f-11e9-8e51-5b87588569be.gif)


Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spong spong

Labels
bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MindyRS @spong @mikecote @elasticmachine