Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Change ML job links have the job configuration in the search #46052

Closed
FrankHassanabad opened this issue Sep 18, 2019 · 1 comment
Closed
Assignees
Labels
enhancement New value added to drive a business result loe:small Small Level of Effort Team:SIEM

Comments

@FrankHassanabad
Copy link
Contributor

FrankHassanabad commented Sep 18, 2019

Kibana version:
7.3.0, 7.4.0

Original install method (e.g. download page, yum, from source, etc.):
cloud

Describe the bug:
When you are an ML admin and open the ML Anomaly detection button and then click on the hyper link to a job it will take you to the ML job page of:

/app/ml

Which lists all of the jobs.
Screen Shot 2019-09-18 at 11 22 08 AM

If you have a lot of jobs to sort through this non-optimal. As an ML admin, you will want to go directly to the job you clicked on by having the search populated. That is possible by changing the link and adding the ml job:

Here is an example of a URL which will populate the search:

/app/ml#/jobs?mlManagement=(jobId:windows_anomalous_process_all_hosts_ecs)

Steps to reproduce:

  1. Be an ML admin or super user
  2. Click on the ML Anomaly detection button and then click on a job id

Screen Shot 2019-09-18 at 11 13 51 AM

Then click on any job id and you just go to the details page.

Expected behavior:
When you click on a job id you are going to have the job ID populated like so:
Screen Shot 2019-09-18 at 11 20 55 AM

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem

@FrankHassanabad FrankHassanabad added enhancement New value added to drive a business result loe:small Small Level of Effort labels Sep 18, 2019
FrankHassanabad added a commit that referenced this issue Sep 20, 2019
…n the user clicks on them. (#46084)

## Summary

* Adds the link for ML search when you click on it. 
* Adds more unit tests
* #46052

When you are an ML admin and open the ML Anomaly detection button and then click on the hyper link to a job it will take you to the ML job page of:
```ts
/app/ml
```
Which lists all of the jobs.
<img width="1405" alt="Screen Shot 2019-09-18 at 11 22 08 AM" src="https://user-images.githubusercontent.com/1151048/65170796-a7b7a480-da06-11e9-9cec-1a912129fb83.png">

If you have a lot of jobs to sort through this non-optimal. As an ML admin, you will want to go directly to the job you clicked on by having the search populated. That is possible by changing the link and adding the ml job:

Now when you click on a job id you are going to have the job ID populated like so:
<img width="1357" alt="Screen Shot 2019-09-18 at 11 20 55 AM" src="https://user-images.githubusercontent.com/1151048/65170720-7a6af680-da06-11e9-9482-84e7cd62763f.png">

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
FrankHassanabad added a commit to FrankHassanabad/kibana that referenced this issue Sep 20, 2019
…n the user clicks on them. (elastic#46084)

## Summary

* Adds the link for ML search when you click on it. 
* Adds more unit tests
* elastic#46052

When you are an ML admin and open the ML Anomaly detection button and then click on the hyper link to a job it will take you to the ML job page of:
```ts
/app/ml
```
Which lists all of the jobs.
<img width="1405" alt="Screen Shot 2019-09-18 at 11 22 08 AM" src="https://user-images.githubusercontent.com/1151048/65170796-a7b7a480-da06-11e9-9cec-1a912129fb83.png">

If you have a lot of jobs to sort through this non-optimal. As an ML admin, you will want to go directly to the job you clicked on by having the search populated. That is possible by changing the link and adding the ml job:

Now when you click on a job id you are going to have the job ID populated like so:
<img width="1357" alt="Screen Shot 2019-09-18 at 11 20 55 AM" src="https://user-images.githubusercontent.com/1151048/65170720-7a6af680-da06-11e9-9482-84e7cd62763f.png">

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
FrankHassanabad added a commit that referenced this issue Sep 20, 2019
…n the user clicks on them. (#46084) (#46209)

## Summary

* Adds the link for ML search when you click on it. 
* Adds more unit tests
* #46052

When you are an ML admin and open the ML Anomaly detection button and then click on the hyper link to a job it will take you to the ML job page of:
```ts
/app/ml
```
Which lists all of the jobs.
<img width="1405" alt="Screen Shot 2019-09-18 at 11 22 08 AM" src="https://user-images.githubusercontent.com/1151048/65170796-a7b7a480-da06-11e9-9cec-1a912129fb83.png">

If you have a lot of jobs to sort through this non-optimal. As an ML admin, you will want to go directly to the job you clicked on by having the search populated. That is possible by changing the link and adding the ml job:

Now when you click on a job id you are going to have the job ID populated like so:
<img width="1357" alt="Screen Shot 2019-09-18 at 11 20 55 AM" src="https://user-images.githubusercontent.com/1151048/65170720-7a6af680-da06-11e9-9482-84e7cd62763f.png">

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result loe:small Small Level of Effort Team:SIEM
Projects
None yet
Development

No branches or pull requests

2 participants